Repository navigation
feat(nav): sit the mini player beside the shrunk floating bar - #2155
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FlowBottomInsetsgives the resting height and a start shift, and each mini bar applies them in its offset and layout lambdas. Nothing recomposes per frame.FlowApp.ktintoFlowBottomChrome.kt(no behaviour change), taking FlowApp from 602 to 553 lines.Stacked on #2154.
Related issue
None, owner request.
Change type
Validation
./gradlew :app:assembleGithubDebug./gradlew :app:testGithubDebugUnitTest(6191 tests, 0 failures; ClearDockedBarTest 2/2, DraggablePlayerGeometryTest 24/24)spotlessCheck,:app:compileFossDebugKotlin)Test device and Android version: Android emulator, API 37, with music playing: scroll down docks the mini player beside the bubble, the full player opens from and closes back to the docked spot, scroll up undocks it above the bar.
Screenshots or recordings
Risk and compatibility
One synced preference key (
bottom_nav_mini_beside). Touches the mini bars' resting geometry (music sheet, background video bar, Play on bar); with the switch off the shift is zero and positions are unchanged.