Repository navigation
chore: land the seek bar, lyrics, sync, crossfade, downloads and immersive lyrics fixes - #2159
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Twelve changes on their own branches, merged here unchanged so they land with one CI run.
fix/wavy-seek-thumb): the played wave is measured from the same centre the M3 slider puts its thumb on, stops before the thumb, and grows in over its first wavelength. Nothing pokes out past the thumb at the start of a song.fix/lyric-press-box): no press highlight box on lyric lines; tapping still plays from that line.feat/lyric-repeat-count): the mini player and lock screen line shows ×2, ×3 after consecutive identical lines (LyricsRepeats.kt).fix/sync-streamed-hash): collection hashes are computed line by line with oneMessageDigestinstead of joining the whole collection into one string, and only when read. Same hash bytes; golden vectors unchanged.perf/sync-received-key-hash): received collections no longer get a whole-collection hash the server sync never reads.refactor/crossfade-skip-split): the skip hold moves fromMusicCrossfader.kttoCrossfadeSkip.kt, no behaviour change.perf/music-preload-next): the music session player preloads 10 s of the next song through Media3PreloadConfiguration, off with Data Saver or the Data saver buffer profile.fix/crossfade-skip-fade-while-loading): if the next song isn't playing 1 s after the hand-off, the old song fades out anyway and the late song comes in with a 400 ms fade. A slow tail no longer jumps the new song to full volume, and tracks without a duration use the player's own.fix/downloads-no-all-files-prompt): the first download no longer opens the All files access page; the Settings row stays.feat/downloads-find-in-picked-folder): when the saved download folder lost its access (after a reinstall), Downloads asks to choose it again, and Find earlier downloads also lists that folder throughDocumentsContract.refactor/now-playing-slots): slot builders move out ofFullMusicPlayerContent.ktintoNowPlayingSlotContent.kt, same pixels.feat/immersive-lyrics-in-place): new switch "Lyrics on the cover" in Player Appearance, off by default and shown with the Immersive background. When on, the lyrics button on phones shows the lyrics in the player over the dimmed cover, with a full-screen button for the sheet. When off, the lyrics button opens the sheet as before.Related issue
Closes #2150
Closes #2148
Closes #2147
Closes #2145
Closes #2076
Closes #1255
Closes #1278
Change type
Validation
./gradlew :app:assembleGithubDebugon this exact combination./gradlew :app:testGithubDebugUnitTeston this combination: 6242 tests, 0 failed; also on each branch, 0 failedktlintCheckand:app:compileFossDebugKotlinon each branch and on this combination;nightly_notes.py --check.Test device and Android version: Xiaomi 2311DRK48G, Android 16
Screenshots or recordings
Risk and compatibility
No Room schema change, no new permissions, no new dependencies. Sync wire format and record bytes are unchanged. Preload fetches up to 10 s of the next song through the existing data source and music cache.