Repository navigation
fix: LAN live crash, crossfade from the notification and Home, repeat count brackets, chip check - #2166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LiveChannel.sendhands each envelope to every transport on its own (deliverLive). A LAN session whose socket is already closing is logged and dropped from the live set instead of throwing out ofNowPlayingand killing the app; the other transports still get the message.SessionPlayer.handleSeeksends a Next or Previous that changes song tocrossfader.skipTo, the same held skip as the in-app buttons, so the old song keeps playing until its tail is ready. Before, the session switched first and the tail was rebuilt from nothing, which left 0.3 to 0.4 s of silence on every press (measured from the reporter's recordings). A Previous that restarts the song, other seeks, a paused player and Play on remote control keep the old path.ACTION_HOLD_FOR_NEW_QUEUE) to move the playing song to a fade tail. Once the tail plays, the app replaces the queue withoutstop()/clearMediaItems(), and the fade runs when the new song plays (or the old one fades out after 1 s if the new one is still loading). If the hold can't start within 1.5 s, the queue goes ahead as before. The app shows the new song right away, as for a held skip.(×2), matching the lock screen's bracket style.FlowFilterChipno longer draws a check on the selected chip; selection shows through the M3 shape morph and fill, and the chip keeps its width.ListenableFuture.await()moved fromDownloadTagReadertoutils/FutureAwait.ktfor its second user.Related issue
Closes #2161
Closes #2162
Closes #2163
Closes #2164
Change type
Validation
./gradlew :app:assembleGithubDebug./gradlew :app:testGithubDebugUnitTest(6252 tests, 46 skipped, 0 failed):app:compileFossDebugKotlin,ktlintCheck,nightly_notes.py --check)Phone pass (debug build, crossfade 5 s with Fade when you skip on), read from the
MusicCrossfaderlogs:START_TAIL). Previous after 3 s restarts the song; Previous within 3 s goes back through the held skip; Next while paused moves on and stays paused.New JVM tests:
LiveDeliveryTest,SessionSkipIndexTest,CrossfadePolicyTest(new-queue rule).Test device and Android version: Xiaomi 2311DRK48G, Android 16
Screenshots or recordings
Risk and compatibility
Playback path: C changes how the media session handles Next/Previous from outside the app; D delays replacing the queue by the tail's start time (about 0.3 to 0.4 s) while the old song keeps playing. Both fall back to the previous behaviour when the crossfader can't hold.
No Room, preference, permission or dependency changes.
The change does not introduce secrets, private data, or unexpected telemetry.
New user-facing text uses Android string resources.
Dependency and lockfile changes are intentional and limited to this PR.
Room schema changes include the required version bump and migration, or this PR does not change the Room schema.
Breaking changes and upgrade steps are clearly documented.