Skip to content

fix: LAN live crash, crossfade from the notification and Home, repeat count brackets, chip check - #2166

Merged
A-EDev merged 6 commits into
mainfrom
fix/issues-2160-2164
Nov 16, 2026
Merged

A-EDev merged 6 commits into
mainfrom
fix/issues-2160-2164

Conversation

@A-EDev

@A-EDev A-EDev commented Nov 16, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • LAN live crash ([Bug]: IOException in WsConnection.send (3.0.0-nightly.2514+0f01bec) #2161, [Bug]: IOException in WsConnection.send (3.0.0-nightly.2525+25bb170) #2162): LiveChannel.send hands each envelope to every transport on its own (deliverLive). A LAN session whose socket is already closing is logged and dropped from the live set instead of throwing out of NowPlaying and killing the app; the other transports still get the message.
  • Notification and headset Next/Previous ([Bug]: corssfade perfectly not working form notification & home page #2163): SessionPlayer.handleSeek sends a Next or Previous that changes song to crossfader.skipTo, the same held skip as the in-app buttons, so the old song keeps playing until its tail is ready. Before, the session switched first and the tail was rebuilt from nothing, which left 0.3 to 0.4 s of silence on every press (measured from the reporter's recordings). A Previous that restarts the song, other seeks, a paused player and Play on remote control keep the old path.
  • Crossfade into a picked song ([Bug]: corssfade perfectly not working form notification & home page #2163): with Fade when you skip on, picking a different song while one plays first asks the service (ACTION_HOLD_FOR_NEW_QUEUE) to move the playing song to a fade tail. Once the tail plays, the app replaces the queue without stop()/clearMediaItems(), and the fade runs when the new song plays (or the old one fades out after 1 s if the new one is still loading). If the hold can't start within 1.5 s, the queue goes ahead as before. The app shows the new song right away, as for a held skip.
  • Repeat count ([Bug]: add bracket "()" #2164): repeated lyric lines show (×2), matching the lock screen's bracket style.
  • Filter chips: FlowFilterChip no longer draws a check on the selected chip; selection shows through the M3 shape morph and fill, and the chip keeps its width.
  • ListenableFuture.await() moved from DownloadTagReader to utils/FutureAwait.kt for its second user.

Related issue

Closes #2161
Closes #2162
Closes #2163
Closes #2164

Change type

  • Bug fix
  • Feature
  • Refactor or maintenance
  • Build, packaging, or CI
  • Documentation

Validation

  • ./gradlew :app:assembleGithubDebug
  • ./gradlew :app:testGithubDebugUnitTest (6252 tests, 46 skipped, 0 failed)
  • I ran any additional flavor-specific build or test tasks affected by this change. (:app:compileFossDebugKotlin, ktlintCheck, nightly_notes.py --check)
  • I manually tested the affected behavior on an Android device or emulator.

Phone pass (debug build, crossfade 5 s with Fade when you skip on), read from the MusicCrossfader logs:

  • Picking a song while one plays: every pick held the old song on a tail (tail start 287 to 1168 ms) before the new queue went in; the late fade ran once when the new song took over 1 s. A pick while paused plays at once with no hold; two picks 0.2 s apart end on the second. A music link opened while playing also fades.
  • Next as a media key (headset path), three times: each went through the held skip (START_TAIL). Previous after 3 s restarts the song; Previous within 3 s goes back through the held skip; Next while paused moves on and stays paused.
  • Filter chips: no check, selected and unselected chips keep the same width.
  • Mini player lyrics: "So, oh, oh-oh-oh (×2)" on C8nObVkgCEM.
  • No crash during the run.

New JVM tests: LiveDeliveryTest, SessionSkipIndexTest, CrossfadePolicyTest (new-queue rule).

Test device and Android version: Xiaomi 2311DRK48G, Android 16

Screenshots or recordings

Risk and compatibility

  • Playback path: C changes how the media session handles Next/Previous from outside the app; D delays replacing the queue by the tail's start time (about 0.3 to 0.4 s) while the old song keeps playing. Both fall back to the previous behaviour when the crossfader can't hold.

  • No Room, preference, permission or dependency changes.

  • The change does not introduce secrets, private data, or unexpected telemetry.

  • New user-facing text uses Android string resources.

  • Dependency and lockfile changes are intentional and limited to this PR.

  • Room schema changes include the required version bump and migration, or this PR does not change the Room schema.

  • Breaking changes and upgrade steps are clearly documented.

@github-actions github-actions Bot added documentation Improvements or additions to documentation player Video and audio playback ui Compose UI, theming, or Material 3 surfaces labels Nov 16, 2026
@A-EDev
A-EDev merged commit fc29c68 into main Nov 16, 2026
9 checks passed
@A-EDev
A-EDev deleted the fix/issues-2160-2164 branch November 16, 2026 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation player Video and audio playback ui Compose UI, theming, or Material 3 surfaces

Projects

None yet

1 participant