Skip to content

feat(topbar): profile button on every main tab, with Settings in its menu as an option - #2169

Merged
A-EDev merged 2 commits into
mainfrom
feat/profile-top-bar
Nov 16, 2026
Merged

A-EDev merged 2 commits into
mainfrom
feat/profile-top-bar

Conversation

@A-EDev

@A-EDev A-EDev commented Nov 16, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • The profile button now shows on every main tab (Home, Music, Subscriptions, Library), next to Notifications and Settings, so people who hide Home can still switch profiles.
  • New switches in Settings > Appearance > Layout: Profile in the top bar (on) and Settings in the profile menu (off, disabled while the profile is hidden).
  • With Settings in the profile menu, the settings icon goes away and the profile sheet gets a Settings row.
  • Subscriptions has two actions of its own, so its profile button holds Settings by default and the bar keeps 4 icons.
  • Hiding the profile keeps the settings icon on every bar, so Settings is always reachable. Profiles stay in Settings > Profiles.
  • One activity-scoped ProfileSwitchViewModel serves every bar, and switch refusals show once from the shell. FlowTopBar(trailingAction) is removed.

Related issue

None filed.

Change type

  • Bug fix
  • Feature
  • Refactor or maintenance
  • Build, packaging, or CI
  • Documentation

Validation

  • ./gradlew :app:assembleGithubDebug
  • ./gradlew :app:testGithubDebugUnitTest (6336 tests, 0 failures; new TopBarAccountTest)
  • I ran any additional flavor-specific build or test tasks affected by this change. (ktlintCheck, :app:compileFossDebugKotlin, python3 .github/scripts/nightly_notes.py --check)
  • I manually tested the affected behavior on an Android device or emulator.

Test device and Android version:

Screenshots or recordings

Risk and compatibility

Two new per-profile preferences in player_preferences (show_profile_in_top_bar, settings_in_profile_menu), carried by settings backup. No Room, permission, network or playback changes. TV keeps its own rail and sheet.

  • The change does not introduce secrets, private data, or unexpected telemetry.
  • New user-facing text uses Android string resources.
  • Dependency and lockfile changes are intentional and limited to this PR.
  • Room schema changes include the required version bump and migration, or this PR does not change the Room schema.
  • Breaking changes and upgrade steps are clearly documented.

@A-EDev
A-EDev merged commit b03535f into main Nov 16, 2026
8 checks passed
@A-EDev
A-EDev deleted the feat/profile-top-bar branch November 16, 2026 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant