Repository navigation
feat(topbar): profile button on every main tab, with Settings in its menu as an option - #2169
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ProfileSwitchViewModelserves every bar, and switch refusals show once from the shell.FlowTopBar(trailingAction)is removed.Related issue
None filed.
Change type
Validation
./gradlew :app:assembleGithubDebug./gradlew :app:testGithubDebugUnitTest(6336 tests, 0 failures; newTopBarAccountTest)ktlintCheck,:app:compileFossDebugKotlin,python3 .github/scripts/nightly_notes.py --check)Test device and Android version:
Screenshots or recordings
Risk and compatibility
Two new per-profile preferences in player_preferences (
show_profile_in_top_bar,settings_in_profile_menu), carried by settings backup. No Room, permission, network or playback changes. TV keeps its own rail and sheet.