Repository navigation
fix: DeArrow frames and thumbnails only switch, whole-song music buffer - #2171
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
maxres2/sd2/hq2/mq2by thumbnail quality) instead of the uploader's thumbnail.dearrow_random_frameadded to the settings sync map.LoadControl, soMusicLoadControlwrapsDefaultLoadControland only caps the forward window while saving data; it forwards each overload the player calls, with a test that none is missing.Related issue
Closes #1633
Closes #2167
Change type
Validation
./gradlew :app:assembleGithubDebug./gradlew :app:testGithubDebugUnitTest(6358 tests, 0 failures)ktlintCheck,:app:compileFossDebugKotlin)Seeks on a fully loaded song (back to 0:10, forward near the end, back, forward), BUFFERING to READY: 127, 65, 61, 105 ms with this change against 150, 650, 280, 580 ms on main (same phone, Wi-Fi, an uncached song each).
Test device and Android version: Xiaomi 2311DRK48G, HyperOS (Android 16); Android emulator API 37
Screenshots or recordings
Risk and compatibility
New preference
dearrow_thumbnails_only(profile store, default off). The music player holds up to 24 MB of audio in memory per song and downloads the rest of a song once it starts, except under Data Saver.