Skip to content

fix: DeArrow frames and thumbnails only switch, whole-song music buffer - #2171

Merged
A-EDev merged 7 commits into
mainfrom
merge/issues-1633-2167
Nov 16, 2026
Merged

A-EDev merged 7 commits into
mainfrom
merge/issues-1633-2167

Conversation

@A-EDev

@A-EDev A-EDev commented Nov 16, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • DeArrow: when DeArrow picks a frame it cannot show yet (its server answers 204 for new videos, or it has no length to place the random frame), cards now fall back to YouTube's automatic middle frame (maxres2/sd2/hq2/mq2 by thumbnail quality) instead of the uploader's thumbnail.
  • New switch in Settings › Integrations › DeArrow: DeArrow thumbnails only. Cards wait for DeArrow's answer instead of loading the uploader's thumbnail first, and every other video thumbnail in the app (library, playlists, queue, mini player, Continue watching) shows YouTube's frame. Shorts, live and upcoming videos and device files keep their own image. "Use a video frame" reads on and is disabled while it is on.
  • Sync: dearrow_random_frame added to the settings sync map.
  • Music: the player now loads the whole song and keeps what has played (10 min ahead and behind, 24 MB cap), so seeking stays in memory instead of opening a new request. With Android's Data Saver or the Data Saver buffer profile on it keeps the old 30 s window; low-RAM devices keep the old profile. Media3 1.11 ships no forwarding LoadControl, so MusicLoadControl wraps DefaultLoadControl and only caps the forward window while saving data; it forwards each overload the player calls, with a test that none is missing.

Related issue

Closes #1633
Closes #2167

Change type

  • Bug fix
  • Feature
  • Refactor or maintenance
  • Build, packaging, or CI
  • Documentation

Validation

  • ./gradlew :app:assembleGithubDebug
  • ./gradlew :app:testGithubDebugUnitTest (6358 tests, 0 failures)
  • I ran any additional flavor-specific build or test tasks affected by this change. (ktlintCheck, :app:compileFossDebugKotlin)
  • I manually tested the affected behavior on an Android device or emulator.

Seeks on a fully loaded song (back to 0:10, forward near the end, back, forward), BUFFERING to READY: 127, 65, 61, 105 ms with this change against 150, 650, 280, 580 ms on main (same phone, Wi-Fi, an uncached song each).

Test device and Android version: Xiaomi 2311DRK48G, HyperOS (Android 16); Android emulator API 37

Screenshots or recordings

Risk and compatibility

New preference dearrow_thumbnails_only (profile store, default off). The music player holds up to 24 MB of audio in memory per song and downloads the rest of a song once it starts, except under Data Saver.

  • The change does not introduce secrets, private data, or unexpected telemetry.
  • New user-facing text uses Android string resources.
  • Dependency and lockfile changes are intentional and limited to this PR.
  • Room schema changes include the required version bump and migration, or this PR does not change the Room schema.
  • Breaking changes and upgrade steps are clearly documented.

@github-actions github-actions Bot added documentation Improvements or additions to documentation player Video and audio playback ui Compose UI, theming, or Material 3 surfaces sync Device-to-device sync labels Nov 16, 2026
@A-EDev
A-EDev merged commit 9ae143c into main Nov 16, 2026
9 checks passed
@A-EDev
A-EDev deleted the merge/issues-1633-2167 branch November 16, 2026 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation player Video and audio playback sync Device-to-device sync ui Compose UI, theming, or Material 3 surfaces

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Music load Releted [Feature]: Only DeArrow thumbnails

1 participant