Repository navigation
fix(security): patch JavaScript build and test dependencies - #3
Merged
Merged
Conversation
Raise the Vite and Vitest dependency floors and resolve patched transitive packages. Vitest 4 replaces the vulnerable tinypool dependency and fixes mocker advisories with no listed fix on the old major. Preserve existing application and test sources, and exercise the frozen workspace install, build, tests and unfiltered audit in CI.
Member
Author
|
Judge: APPROVED at exact head
I did not reproduce the before-state audit count independently; the after-state is verified by the CI audit step. Non-blocking: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The JavaScript toolchain still contained 16 audit findings, including two critical tinypool advisories. This updates Vite to 7.3.7 and Vitest to 4.1.12, refreshes the affected PostCSS/browser/source-map dependencies, and removes tinypool through the supported Vitest 4 dependency graph. No advisory ignores or forced dependency overrides are added.
Vitest 3 has no listed fix for the current mocker advisories, so this includes a tested major-version migration. Existing application and test sources are unchanged. A new Linux workflow runs the same frozen install, TypeScript/Vite build, workspace tests and full audit on pull requests and master pushes, with Node 26.12.1 and pnpm 12.15.0.
Validation on macOS arm64: frozen install, all workspace tests, TypeScript packages and Studio production build, actionlint and whitespace checks pass. Fresh unfiltered pnpm audit changes from 16 findings (2 critical, 5 high, 8 moderate, 1 low) to zero. CI and independent review remain required. This covers source/build tooling; it does not assert desktop deployment coverage.
Closes #2.