Skip to content

fix: 评论私密接口未授权风险和无法切换私密状态 #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Shiroiame-Kusu merged 1 commit into from
Aug 16, 2026
Merged

fix: 评论私密接口未授权风险和无法切换私密状态 #75

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions src/page/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,17 +236,13 @@ function sm() {
cm.addEventListener("click", (e) => {
let list = e.target.parentNode;
if (list.classList.contains("sm")) {
let msg = __("您真的要设为私密吗？");
let msg = __("您确定要切换私密状态吗？");
if (confirm(msg) == true) {
if (list.classList.contains('private_now')) {
alert(__('您之前已设过私密评论'));
return false;
} else {
list.classList.add('private_now');
let idp = list.getAttribute("data-idp"),
actionp = list.getAttribute("data-actionp"),
rateHolderp = list.getElementsByClassName('has_set_private')[0];
let ajax_data = "action=siren_private&p_id=" + idp + "&p_action=" + actionp;
rateHolderp = list.getElementsByClassName('has_set_private')[0],
noncep = list.getAttribute("data-noncep");
let ajax_data = "action=siren_private&p_id=" + idp + "&p_action=" + actionp + "&_wpnonce=" + noncep;
Comment on lines 241 to +245

@ranfey ranfey Aug 9, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

后端校验的是绑定评论 ID 的 siren_private_{comment_id} nonce，不是全局 nonce

@ranfey ranfey Aug 9, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

在另一个仓库 mirai-mamori/Sakurairo#1422

let request = new XMLHttpRequest();
request.onreadystatechange = function () {
if (this.readyState == 4 && this.status == 200) {
Expand All @@ -257,7 +253,6 @@ function sm() {
request.setRequestHeader("Content-type", "application/x-www-form-urlencoded");
request.send(ajax_data);
return false;
}
}
}
})
Expand Down