add proxmox terminal support - #90
Draft
june-fish wants to merge 5 commits into
Draft
Conversation
Member
|
issue with this is that websockets also wont work in cloudflare, i planned on setting up a microservice for this on the proxmox nodes so that we could avoid doing cloudflare durable objects for it (they dont work well within frameworks) |
Contributor
Author
|
whoops lol, forgot about that. i might look into writing that microservice soon.
…On July 30, 2026 8:25:35 PM CDT, addison ***@***.***> wrote:
addidotlol left a comment (FyraStack/dashboard#90)
issue with this is that websockets also wont work in cloudflare, i planned on setting up a microservice for this on the proxmox nodes so that we could avoid doing cloudflare durable objects for it (they dont work well within frameworks)
--
Reply to this email directly or view it on GitHub:
#90 (comment)
You are receiving this because you authored the thread.
Message ID: ***@***.***>
|
Member
|
if you want i can do it later today and wire it up in the pr. theres some other changes i wanna make along with it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Terminal does not work when vite is being used to serve the dashboard as it does not support websockets. So, I changed the default dev command to use wrangler instead of vite. But it is much slower to rebuild now, it might be worth keeping vite as default and adding a note in the dev README about that instead. Currently the terminal is a tad finicky for me but mostly works, I will do some more debugging on this soon.