Repository navigation
Conversation
…lace model updates
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Revision detection can miss model updates, and evicted live graphs can later be loaded twice.
2 open findings
What changed in this PR
Introduces shared WASI-NN graph caching, single-flight loading, and model revision detection outside request paths.
Changes:
- Shares graph registries across engines and stores.
- Preloads models on blocking executor creation.
- Adds cache lifecycle, revision, and loading tests.
| File | Description |
|---|---|
src/main.rs |
Initializes the shared registry. |
src/context.rs |
Offloads executor compilation and model preload. |
crates/runtime/src/store.rs |
Adds explicit WASI-NN preloading. |
crates/runtime/src/service.rs |
Propagates the shared registry. |
crates/runtime/src/registry.rs |
Implements graph caching and revision tracking. |
crates/runtime/src/lib.rs |
Exposes and threads registry state. |
crates/runtime/Cargo.toml |
Adds test filesystem support. |
crates/http-service/src/lib.rs |
Handles optional WASI-NN contexts. |
crates/http-service/src/executor/http.rs |
Updates test context integration. |
Cargo.lock |
Records the test dependency. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.