Skip to content

docs: fix cache::set and secret::get rustdoc examples - #90

Merged
ruslanti merged 2 commits into
mainfrom
fix/doc-examples-cache-set-secret-get
Oct 9, 2026
Merged

ruslanti merged 2 commits into
mainfrom
fix/doc-examples-cache-set-secret-get

Conversation

@ruslanti

@ruslanti ruslanti commented Oct 9, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@ruslanti
ruslanti requested a review from qrdl October 9, 2026 08:43
@ruslanti ruslanti self-assigned this Oct 9, 2026
Copilot AI balanced review requested due to automatic review settings October 9, 2026 08:43
@ruslanti ruslanti added the documentation Improvements or additions to documentation label Oct 9, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The documentation examples now align with the APIs and existing usage.

0 open findings

What changed in this PR

Corrects Rustdoc examples to match current secret and cache API types.

Changes:

  • Treat secret values as String.
  • Pass byte slices to cache::set.
File Description
src/​lib.rs Fixes secret and cache documentation examples.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@ruslanti
ruslanti merged commit 6bd0184 into main Oct 9, 2026
8 checks passed
@ruslanti
ruslanti deleted the fix/doc-examples-cache-set-secret-get branch October 9, 2026 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants