Skip to content

fix(icons): address review feedback on resets and filter types - #263

Merged
G3root merged 1 commit into
mainfrom
fix/icons-review-followup
Nov 19, 2026
Merged

G3root merged 1 commit into
mainfrom
fix/icons-review-followup

Conversation

@G3root

@G3root G3root commented Nov 19, 2026

Copy link
Copy Markdown
Owner

Summary

Follow-up to #259 for the review comments that landed after it was merged. All findings were verified against the current main.

  • Icon resets — IconPickerField now emits null when the selected icon is the entity default, so choosing the default is the same “no override” state as “Use default”. The board rename and status edit forms track picker interaction with a ref, not a comparison against a captured value. An untouched icon is omitted from the update, while an explicit default selection persists null even if a refetch changes the collection row.
  • Roadmap drop — handleDragEnd now prefers the synchronous dragState.targetStatusId over the committed preview, keeping the existing element fallback.
  • Picker accessibility — the popup receives aria-label={label}; the trigger’s label is unchanged.
  • Sprite URL — sprite.ts resolves the static new URL(..., import.meta.url) lazily inside the loader, after the browser check, so server module evaluation never evaluates it.
  • Home filter types — HomeFilterItem is now a discriminated union for all, board, and status rows. Board/status fields derive from TBoard/TPostStatus, and status rows require statusType.
  • Recent-post projections — board and status interfaces are Picks of TBoard/TPostStatus, preserving icon nullability and status vocabulary.
  • Post form board type — PostBoardSelectProps is exported, and the shared form state derives its boards type from PostBoardSelectProps["boards"].

Validation

  • pnpm check
  • Web board tests: 12
  • Public feature board tests: 23
  • Post UI status/roadmap tests: 12
  • Web-shared icon defaults tests: 3

The picker now emits null when the selected icon is the entity default, and the board/status edit forms track picker interaction instead of comparing against a captured value, so an untouched icon is omitted while an explicit default selection persists null even after a refetch. The roadmap drop reads the synchronous drag target first. The picker popup gets an accessible name, and the sprite URL is resolved lazily after the browser check so server module evaluation does not touch import.meta.url. Home filter rows are a discriminated union, recent-post projections derive from the domain rows, and the post form's board list derives its type from PostBoardSelect.
@coderabbitai

coderabbitai Bot commented Nov 19, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 11 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 82461632-2c02-49c3-bbb9-6ad6b255864c
Commits

Reviewing files that changed from the base of the PR and between f1374ec and 80ddf82.

Files selected for processing: 12

  • apps/public-feature-board/src/features/home/components/board-select.tsx
  • apps/public-feature-board/src/features/home/components/status-menu.tsx
  • apps/public-feature-board/src/features/home/home-context.ts
  • apps/public-feature-board/src/features/home/home-provider.tsx
  • apps/web/src/dashboard/features/board/components/rename-board-dialog.tsx
  • apps/web/src/dashboard/features/dashboard-home/components/recent-posts-section.tsx
  • apps/web/src/dashboard/features/post-status/components/post-status-edit-dialog.tsx
  • apps/web/src/dashboard/features/roadmap/components/roadmap-board.tsx
  • packages/post-ui/src/forms/post-create-form-shared.tsx
  • packages/post-ui/src/post-field.tsx
  • packages/ui/src/icon-picker/index.tsx
  • packages/ui/src/icon-picker/sprite.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@G3root
G3root merged commit 49acecc into main Nov 19, 2026
10 checks passed
@G3root
G3root deleted the fix/icons-review-followup branch November 19, 2026 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant