Repository navigation
fix(icons): address review feedback on resets and filter types - #263
Merged
Merged
Conversation
The picker now emits null when the selected icon is the entity default, and the board/status edit forms track picker interaction instead of comparing against a captured value, so an untouched icon is omitted while an explicit default selection persists null even after a refetch. The roadmap drop reads the synchronous drag target first. The picker popup gets an accessible name, and the sprite URL is resolved lazily after the browser check so server module evaluation does not touch import.meta.url. Home filter rows are a discriminated union, recent-post projections derive from the domain rows, and the post form's board list derives its type from PostBoardSelect.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 11 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #259 for the review comments that landed after it was merged. All findings were verified against the current
main.IconPickerFieldnow emitsnullwhen the selected icon is the entity default, so choosing the default is the same “no override” state as “Use default”. The board rename and status edit forms track picker interaction with a ref, not a comparison against a captured value. An untouched icon is omitted from the update, while an explicit default selection persistsnulleven if a refetch changes the collection row.handleDragEndnow prefers the synchronousdragState.targetStatusIdover the committed preview, keeping the existing element fallback.aria-label={label}; the trigger’s label is unchanged.sprite.tsresolves the staticnew URL(..., import.meta.url)lazily inside the loader, after the browser check, so server module evaluation never evaluates it.HomeFilterItemis now a discriminated union forall,board, andstatusrows. Board/status fields derive fromTBoard/TPostStatus, and status rows requirestatusType.Picks ofTBoard/TPostStatus, preserving icon nullability and status vocabulary.PostBoardSelectPropsis exported, and the shared form state derives itsboardstype fromPostBoardSelectProps["boards"].Validation
pnpm check