Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 11 additions & 10 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion pnpm-workspace.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,8 @@ minimumReleaseAgeExclude:
# no other home, so this file carries the old Yarn pins and scoped security
# fixes. Yarn's `**/a/b` globs become pnpm's `a>b` selectors.
overrides:
"@expo/plist>@xmldom/xmldom": 0.8.13
"@expo/plist>@xmldom/xmldom": 0.8.15
"plist>@xmldom/xmldom": 0.9.12
"@typescript-eslint/typescript-estree>minimatch": 9.0.7
brace-expansion@<1.1.18: ^1.1.18
brace-expansion@>=4.0.0 <5.0.9: ^5.0.9
Expand Down
44 changes: 43 additions & 1 deletion tools/dependency-security-check.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,44 @@ assert.equal(randomCalls, 0);
const pnpmStore = join(process.cwd(), "node_modules/.pnpm");
const installedPackages = readdirSync(pnpmStore);

const packageInStore = (name, version) => {
const directory = installedPackages.find((entry) =>
entry.startsWith(`${name.replace("/", "+")}@${version}`),
);

assert.ok(directory, `${name} ${version} is installed`);

return join(pnpmStore, directory, "node_modules", name, "package.json");
};

for (const version of ["0.8.15", "0.9.12"]) {
const packageJson = packageInStore("@xmldom/xmldom", version);
const { DOMImplementation, XMLSerializer } =
requireFrom(packageJson)("@xmldom/xmldom");
const document = new DOMImplementation().createDocument(null, "root", null);

assert.throws(
() => document.createEntityReference("safe; <injected/> &x"),
/not a valid xml name/,
);

const reference = document.createEntityReference("safe");
reference.nodeName = "safe; <injected/> &x";
const serializer = new XMLSerializer();
const serialize =
version === "0.8.15"
? () =>
serializer.serializeToString(reference, false, undefined, {
requireWellFormed: true,
})
: () =>
serializer.serializeToString(reference, {
requireWellFormed: true,
});

assert.throws(serialize, /not a valid XML Name/);
}

for (const version of ["3.15.1", "4.3.1"]) {
const directory = installedPackages.find((entry) =>
entry.startsWith(`js-yaml@${version}`),
Expand Down Expand Up @@ -177,6 +215,10 @@ for (const version of ["3.15.1", "4.3.1"]) {
}

for (const vulnerablePackage of [
"@xmldom+xmldom@0.8.13",
"@xmldom+xmldom@0.8.14",
"@xmldom+xmldom@0.9.10",
"@xmldom+xmldom@0.9.11",
"js-yaml@3.15.0",
"js-yaml@4.3.0",
"nanoid@3.3.16",
Expand All @@ -190,5 +232,5 @@ for (const vulnerablePackage of [
}

console.log(
"Dependency security checks passed for js-yaml, nanoid and image-size.",
"Dependency security checks passed for @xmldom/xmldom, js-yaml, nanoid and image-size.",
);