Repository navigation
series: rebase onto FEX-2611 and take the offline code cache fixes (gn-6) - #9
Merged
Merged
Conversation
…n-6) Upstream merged the NtDllRedirectionLUTSize load (FEX#6021) and the kept guest loads (FEX#6069), so 0002 and 0007 are dropped. FEX-2611 also delivers JIT-raised guest faults on arm64ec without a host trap and passes the partial-fault address itself, so 0001 loses its VirtualQuery heuristic and hooks its stale NoExec retry into the new synchronous handler, and 0003 keeps only the fast raise (FEX_EXP_FASTTRAP is gone). The seven code cache patches from #7 follow as 0006-0012, and the package ships FEXOfflineCompiler32/64.exe in system32.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the series from FEX-2610 to FEX-2611 and folds in the seven offline code cache patches from #7 (which this supersedes). 12 patches,
SERIES_VERSION6. The regenerated series applies with plaingit amon a fresh FEX-2611 checkout and the tree matches the 3-way result byte for byte.What changed at the rebase:
SynchronousExceptionHandler(27cfd41, 07abec3) instead of trapping withhlt/brk. That makes tarikbc's trapless path in 0003 redundant, so it is dropped together withFEX_EXP_FASTTRAP; the fast raise intoKiUserExceptionDispatcherstays and now hangs off upstream'sRaiseException.DropStaleNoExecFault(state already synced) and calls it from both the host path and the synchronous handler, re-entering the dispatcher through a smallEnterDispatcherFillSRAthunk in Module.S.VirtualQuerypage heuristic inHandleGuestExceptionis removed.FEXOfflineCompiler32/64.exein system32 as in Fix the offline code cache on WoW64 and ship the offline compilers #7.Not yet run on a device. The two 2611-specific pieces that need a check are the synchronous-path NoExec retry (D2R or Overwatch 2) and fast raise on top of upstream's handler (AoE IV).