Repository navigation
icd_shim: keep Xwayland on the payload driver - #70
Open
borodatych wants to merge 1 commit into
Open
borodatych wants to merge 1 commit into
borodatych wants to merge 1 commit into
Conversation
Xwayland's glamor renders through zink on this shim, and the shim loads whatever ADRENOTOOLS_DRIVER_PATH points at, i.e. the container's Turnip. Importing client buffers there leaks one dma-buf fd per buffer: on an AYN Thor (Adreno 740) Xwayland went from 758 to 3199 dma-buf fds in 40 s under a CEF launcher, and Android killed the app within ~3 minutes. Turnip v26.2.0 R4 and 26.0.0 R8 both leak; the payload's own driver does not (Xwayland holds 9-18 buffers and the count stays flat). Turning adrenotools off for the whole container is not an option: guest launchers stop rendering. So only the Xwayland process skips try_adrenotools; games keep the container driver.
Collaborator
Hi @borodatych thanks for the suggestion, could you confirm whether the leak is only happening when using with Ubisoft Connect launcher? |
Contributor
|
@joshuatam maybe any CEF launcher? But afaik they don't really work well in GN anyway |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Under gamescope, Xwayland's glamor renders through zink on this shim, and the shim loads the driver from
ADRENOTOOLS_DRIVER_PATH— the container's Turnip.Importing client buffers there leaks one dma-buf fd per buffer.
Measured on an AYN Thor (Adreno 740), with the Ubisoft Connect (CEF) launcher open:
wl_buffer(WAYLAND_DEBUG: 2584 attach, 2581 release), so the fds pile up inside Xwayland's driver.libvulkan_freedreno.sodoes not.Fix
Only the Xwayland process skips
try_adrenotools()and stays on the payload driver.Games keep the container's driver.
GN_VKSHIM_NO_ADRENOTOOLS=1on the whole container is not a substitute: guest launchers stop rendering with it.Tested
20261105.4: Xwayland holds 9–18 dma-buf fds and the count stays flat for minutes; the game still loads the container's Turnip.cargo build --release --lockedandcargo clippyforadrenotools_gamescopewith-D warnings: clean.