Skip to content

Coverage gaps: valve id bug, screen/glob steps, service-pack byte ranges, .NET tool hops - #1

Merged
utkarshdalal merged 7 commits into
mainfrom
coverage-gaps
Oct 11, 2026
Merged

utkarshdalal merged 7 commits into
mainfrom
coverage-gaps

Conversation

@utkarshdalal

Copy link
Copy Markdown
Collaborator

Closes the coverage gaps left after the first import.

Valve tables. sync_appcache() returns early when SteamGameId is ''. The converter read that as an app-id check and wrote data/valve/.json. App-id predicates now need digit strings. There is a new test for this.

Partial documents → full (468/468).

  • steam/497360: int(w / h * 768) becomes ${screen_w_h768}, which is floor(screen_w * 768 / screen_h). The app already expands ${screen_w}/${screen_h}. It needs this new name, and it already skips a step whose placeholder it does not know.
  • steam/950670: a Path.glob() loop that only unlinks files becomes {"op":"file","action":"delete","glob":true,"minSizeBytes":11000000}.

Service-pack DLLs (gdiplus, usp10, oleaut32, crypt32, wininet, urlmon, msxml3) are now download verbs. Each file entry has these hops:
{"type":"range",url,sha256,offset,length,rangeSha256,header} → {"type":"cab","member":...} (a second cab hop for msasn1 inside W2KSP4). Each DLL sits in one LZX folder of the outer cabinet. ranges.py cuts the folder after the block where the DLL ends. It also writes a small base64 cabinet header that the app puts in front of the slice. The header is needed because the original header is hundreds of MB away. bsdtar and cabextract both unpack every DLL from header+slice, with the same sha256 as a full cabextract -F of the whole exe. Slices are 12–84 MB, not 129–903 MB.

.NET layouts (16 new). A new hop type, {"type":"tool","tool":"cabextract"|"7zz","member":...}, and an archive-level tool. Layouts and verbs list requiresTools and dictSizeBytes (64 MB for 4.0/4.5, 512 MB for 4.5.2–4.8). libarchive fails on two things: BCJ2 7z self-extractors, and WiX cabinets whose file entries are not contiguous ("Invalid CAB header"). Every layout was replayed hop by hop, and all files were present with the correct sizes. data/tools.json lists the Termux aarch64 cabextract and 7zip debs (7zz also needs libc++_shared.so). Still without a layout: dotnet20 and dotnet20sp2 (their files are outside the cabinets), and dotnet35 and dotnet35sp1 (these are .exe/.msp chains).

Verb classes before → after: download 26→33, offline_installer 29 (9→25 with layouts), skip 18→11.

Utkarsh Dalal added 7 commits October 11, 2026 17:03
sync_appcache() returns early when SteamGameId is '', which the converter read as an
app-id check and wrote data/valve/.json. App-id predicates now need every literal to be
a digit string. Adds a test and regenerates data/valve.
…deletes

int(w / h * N) on get_resolution() becomes ${screen_w_h<N>}, and REG_DWORD/hex() keep
screen placeholders. A Path.glob() loop that only unlinks matches becomes a file delete with
glob: true and an optional minSizeBytes from a st_size threshold. steam/497360 and
steam/950670 are now full.
tools/verbs/ranges.py finds the LZX folder of the Windows 7 SP1 and Windows 2000 SP4
cabinets that holds each DLL, cuts it after the block where the DLL ends and writes a small
cabinet header for that slice. bsdtar and cabextract must both unpack the DLL from header +
slice, with the same sha256 as a full extraction. ranges.json is read by verbs.py, which turns
gdiplus, usp10, oleaut32, crypt32, wininet, urlmon and msxml3 into download verbs with range
and cab hops. Slices are 11-80 MB instead of 129-903 MB downloads.
Members that only cabextract or 7z can read get a {type: tool} hop (or a tool field on the
archive) instead of failing the layout. 7z self-extractors are sliced out of the exe and record
dictSizeBytes. Layouts list requiresTools, which verbs.py copies into verbs.json. SetupCache
files the chainer copies itself are left out with a note, root-level full-framework MSIs are
preferred, dotnet452 uses its GDR packages, and dotnet35/35sp1 are refused (only MSXML 6 would be
laid out). The sync workflow installs 7zip.
device_tools.py reads the termux-main aarch64 index, checks each .deb sha256, takes the binary
from data.tar.xz and reads its DT_NEEDED list. 7zz needs libc++_shared.so, so the libc++ .deb
is listed too; cabextract needs only libc.
REPORT.md gets a Verb classes section with byte-range slice sizes, layout tool needs and
skip reasons. 16 .NET layouts are new.
SCHEMA_NOTES describes the byte-range files, requiresTools/dictSizeBytes and tools.json.
README points at GameNative/gamenative-protonfixes and fixes.gamenative.app.
@utkarshdalal
utkarshdalal merged commit a68568c into main Oct 11, 2026
1 check passed
@utkarshdalal
utkarshdalal deleted the coverage-gaps branch October 11, 2026 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant