Repository navigation
ci: pin Xwayland to gamenative-xwayland-24.1.15 - #40
Merged
Merged
Conversation
The Xwayland checkout followed `ref: gamenative`, a moving branch, while the payload ships the Xwayland it was built against. A CI build then depends on whatever landed on that branch since -- and this is the component whose presentation path the ICD shim binds to, so a silent change there is the kind of difference that only shows up on a device. Pinned to the branch the local builds and the device runs use.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pins the Xwayland checkout in the CI workflow.
ref: gamenativeis a moving branch, while the payload ships the Xwayland it was built against. That makes a CI build depend on whatever landed there since — and Xwayland is the component whose presentation path the ICD shim binds to, so a difference there is one that only shows up on a device.Pinned to
gamenative-xwayland-24.1.15, the branch the local builds and the device runs use.One file, one line of behaviour:
.github/workflows/android-build.yml.Nothing else about the build changes; the rest of the workflow still fetches every other dependency as before.