Skip to content

docs(specs): archive spec 026 and bump website (T033, T036) - #843

Merged
ValgulNecron merged 2 commits into
masterfrom
spec-026/archive
Nov 8, 2026
Merged

ValgulNecron merged 2 commits into
masterfrom
spec-026/archive

Conversation

@ValgulNecron

@ValgulNecron ValgulNecron commented Nov 6, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

This is the last PR for spec 026 (modular dev containers).

  • T033: bumps website to 5457d75. That is website#28, which lists the dev container profiles on the local setup page and links the docs/contributing.md table.
  • T036: marks the task done, moves specs/026-modular-dev-containers to specs/done_026-modular-dev-containers (CLAUDE.md rule 16), and points the in-repo references at the new path. The references are in the spec's own tasks.md, plan.md and inventory.md, and in the docstring of hack/gen-devcontainers.py.

Every task in the spec is now [X]. The earlier PRs are #754, #809, #810, #813, website#26, #27 and #28, and module#53, #54 and #55.


Generated by Claude Code

Summary by CodeRabbit

  • Documentation
    • Updated references to the modular development-container specifications to use their archived location, including links in the inventory, plan, and task documentation.
    • Marked the related specification tasks as complete and updated their recorded paths.
    • Updated the development-container generator’s documentation reference to point to the completed specification contracts.

Points website at 5457d75 (website#28 merged): the local setup page now
lists the dev container profiles and links the docs/contributing.md table.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Claude <noreply@anthropic.com>
Every task in specs/026-modular-dev-containers is done and its PRs are
merged, so move it to specs/done_026-modular-dev-containers and point the
in-repo references at the new path (CLAUDE.md rule 16, T036).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Claude <noreply@anthropic.com>
@ValgulNecron ValgulNecron added area: specs spec-kit feature specs and design docs type: docs Documentation only labels Nov 6, 2026 — with Claude
@ValgulNecron ValgulNecron self-assigned this Nov 6, 2026
@coderabbitai

coderabbitai Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

Spec 026 task records and documentation references now use the archived directory. T033, T035, and T036 are marked complete. The website subproject reference points to a different commit.

Changes

Spec 026 completion and archive

Layer / File(s) Summary
Update completion records and archive references
specs/done_026-modular-dev-containers/tasks.md, specs/done_026-modular-dev-containers/plan.md, specs/done_026-modular-dev-containers/inventory.md, hack/gen-devcontainers.py, website
Task paths and documentation references now use the archived Spec 026 directory. T033, T035, and T036 are marked complete. The website subproject commit reference changed; its contents are not available here.

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Other

Possibly related PRs

Suggested labels: type: docs, type: chore, area: specs

Merge Risk: Low · up to 302c3

The spec was archived before its final pointer update merged. This is a narrow repository-process violation; retain the spec at its original path until that update merges, or explicitly accept the ordering exception.

Pre-merge checks: Passed 5

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title identifies the spec 026 archive and the website reference update.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files. (4 skipped: 4 unsupported.)

Finishing Touches

Generate docstrings

  • Commit to this branch
  • Create a new PR
Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 973aa12 and 302c327.

Files selected for processing: 15

  • hack/gen-devcontainers.py
  • specs/done_026-modular-dev-containers/OPEN-DECISIONS.md
  • specs/done_026-modular-dev-containers/checklists/requirements.md
  • specs/done_026-modular-dev-containers/contracts/generator-cli.md
  • specs/done_026-modular-dev-containers/contracts/profiles-catalogue.md
  • specs/done_026-modular-dev-containers/contracts/setup-and-need.md
  • specs/done_026-modular-dev-containers/contracts/system-deps-format.md
  • specs/done_026-modular-dev-containers/data-model.md
  • specs/done_026-modular-dev-containers/inventory.md
  • specs/done_026-modular-dev-containers/plan.md
  • specs/done_026-modular-dev-containers/quickstart.md
  • specs/done_026-modular-dev-containers/research.md
  • specs/done_026-modular-dev-containers/spec.md
  • specs/done_026-modular-dev-containers/tasks.md
  • website

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Recent review details

Context from checks skipped due to timeout: 26

  • GitHub Check: dependency review
  • GitHub Check: submodule freshness
  • GitHub Check: docs and repository checks
  • GitHub Check: build (modules-gp, arm64)
  • GitHub Check: build (website, arm64)
  • GitHub Check: build (modules-gp, amd64)
  • GitHub Check: build (dashboard-api, arm64)
  • GitHub Check: build (control-plane, arm64)
  • GitHub Check: build (control-plane, amd64)
  • GitHub Check: build (full, arm64)
  • GitHub Check: build (full, amd64)
  • GitHub Check: build (modules, amd64)
  • GitHub Check: build (agent, amd64)
  • GitHub Check: build (modules, arm64)
  • GitHub Check: build (dashboard-api, amd64)
  • GitHub Check: build (website, amd64)
  • GitHub Check: build (agent, arm64)
  • GitHub Check: build (go-services, arm64)
  • GitHub Check: build (api, arm64)
  • GitHub Check: build (go-services, amd64)
  • GitHub Check: build (web, arm64)
  • GitHub Check: build (operator, arm64)
  • GitHub Check: build (operator, amd64)
  • GitHub Check: build (api, amd64)
  • GitHub Check: build (web, amd64)
  • GitHub Check: CodeRabbit
Additional context used

Code guidelines: 2

specs/done_026-modular-dev-containers/spec.md — configured
docs/contributing.md — auto-discovered
Path-based instructions: 2

Source excerpt: **FR-001**: The repository MUST offer several named dev container profiles that a dev-container-capable editor lists for the contributor to pick from when opening the repository.

CodeRabbit inference engine (specs/done_026-modular-dev-containers/spec.md)

Files:

  • specs/done_026-modular-dev-containers/inventory.md
  • specs/done_026-modular-dev-containers/plan.md
  • specs/done_026-modular-dev-containers/tasks.md
Applicability reference: AGENTS.md: # Gameplane — AI assistant guide Architecture, commands, and binding rules for AI agents.

CodeRabbit inference engine (docs/contributing.md)

Files:

  • specs/done_026-modular-dev-containers/inventory.md
  • specs/done_026-modular-dev-containers/plan.md
  • specs/done_026-modular-dev-containers/tasks.md
Learnings: 1

Learning: 2026-10-31T14:29:31.501Z

Learnt from: CR
Repo: GameplanePanel/Gameplane PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-10-31T14:29:31.501Z
Learning: Source excerpt:
# Gameplane — AI assistant guide

## Core rules

16. **Archival:** once every task is complete/withdrawn and the PR is merged into `master`, `git mv specs/<NNN>-<slug> specs/done_<NNN>-<slug>` and update in-repo references in the same commit.

Applied to files:

  • specs/done_026-modular-dev-containers/tasks.md
LanguageTool

specs/done_026-modular-dev-containers/tasks.md

[style] ~37-~37: Try using a synonym here to strengthen your writing.
Context: ... .devcontainer/post-create.sh invoke. Give file:line evidence for each entry. Al...

(GIVE_PROVIDE)

@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown

CI Report - 302c327

run 42266976331 - attempt 1

0 failed - 4 passed - 29 skipped - 5m5s elapsed

Test selection: partial - per-suite table

Coverage

no coverage/* commit statuses found on 302c327

Changed

Area Files +/-
specs/ 13 +8/-8
hack/ 1 +1/-1
(root) 1 +1/-1

Slowest jobs

Job Duration
docs and repository checks 1m5s
detect changes 26s
submodule freshness 21s
move parity (spec 028) 14s
telemetry default gate 7s

e2e buckets run

multicluster, upgrade

@ValgulNecron
ValgulNecron merged commit 988db26 into master Nov 8, 2026
62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: specs spec-kit feature specs and design docs type: docs Documentation only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants