Ruff: Enable RUF105 'noqa-comments' and bump to Ruff>=0.15.22#4761
Open
seisman wants to merge 5 commits into
Open
Ruff: Enable RUF105 'noqa-comments' and bump to Ruff>=0.15.22#4761seisman wants to merge 5 commits into
seisman wants to merge 5 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ruff supports two types of comments for suppressing linting errors:
# noqaand# ruff: ignore(xref: https://docs.astral.sh/ruff/linter/#error-suppression). The# noqasyntax originates fromflake8, whereas# ruff: ignoreis Ruff-specific and provides greater flexibility. For example:This means we can write
# ruff: ignore[unused-import], which is more readable than either# ruff: ignore[F401]or# noqa: F401.This PR enables the
RUF105rule, which automatically detects# noqacomments that can be expressed as# ruff: ignoreand performs the conversion.Note that
RUF105is still a preview rule and requires Ruff 0.15.22 (released on 2026-07-16). I'm happy to postpone this PR if you think adopting a preview feature at this stage is too aggressive.Will explore
RUF106andRUF201in futher PRs.Related to #2741.