Repository navigation
Add invalid well test cases - #48
Merged
Merged
Conversation
Most of the well cases do not reference acquisitions, and so don't need to be in a plate hierarchy. The non_integer_acquisition_id case does.
The well minimal_acquisitions test needs to exist in a plate hierarchy, which means that the test is identical to the plate minimal_acquisitions case.
kevinyamauchi
left a comment
kevinyamauchi
left a comment
Collaborator
There was a problem hiding this comment.
Thanks, @clbarnes ! The new cases look good. I noticed that some of the zarr.json metadata is missing the ome and version attributes. I think they are both pre-existing issues from #13 .
- cases/validate_zarr/v0.6/core/invalid/well/duplicate_images.ome.zarr/zarr.json (I know it was just a rename, but probably good to fix)
- cases/validate_zarr/v0.6/core/invalid/well/empty_images.ome.zarr/zarr.json (not in this PR, but it's next door, so probably worth fixing)
Collaborator
Author
|
Good find, both are fixed now! |
kevinyamauchi
approved these changes
Oct 28, 2026
kevinyamauchi
left a comment
kevinyamauchi
left a comment
Collaborator
There was a problem hiding this comment.
Thank you! LGTM! Is that the last of #17?!?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rounding out the #17 todo list! 🍾