Repository navigation
fix: restore invalid v0.6 multiscale transform cases - #50
tlambert03 wants to merge 1 commit into
Conversation
kevinyamauchi
left a comment
There was a problem hiding this comment.
Thanks, @tlambert03 ! I agree that the current cases are valid and thus incorrect as an "invalid" case. I also agree that the change makes the cases invalid for the
This would be fine to merge as-is for me as it is for sure more correct. However, I am not 100% confident that I know which rule the cases were originally intended to test, so I think it would be good to get input from @clbarnes .
As a side-note, this is a situation where having descriptions for the cases (#46 ) or having codes for the rules in the spec would be helpful.
|
Thanks folks, certainly possible these got swept up with bulk updates. It looks like there aren't equivalent validate_zarr cases for these tests - perhaps there should be? That might be a good unit test, actually: checking whether each parse_attributes has a validate_zarr and that the parse_attributes metadata appears somewhere in that hierarchy. |
invalid_multiscale_transform_outputandinvalid_multiscale_transform_input_outputinparse_attributes/v0.6/core/invalid/imagehave become identical, and both seem totally valid to me (they passimage.schemafrom ngff-spec, and I can't find a rule in the prose that they break).I think this might have been accidental in #22: the path-to-name and string-to-object updates there also rewrote the values these two cases were testing. This restores what they have upstream, so
_outputhas"output": {"path": "intrinsic"}and_input_outputhas"input": "s0", "output": "intrinsic". Both fail the schema again.