Repository navigation
Conversation
A label image must implement the multiscales specification (0.4: "image-label groups MUST also contain multiscales metadata"; 0.5 and 0.6: "The zarr.json file for the label image MUST implement the multiscales specification"). The valid parse_attributes label cases had only image-label, so a reader that follows the text refused them. They now carry the multiscales of their validate_zarr twins, and a missing_multiscales case holds the old document, as a parse_attributes document and as a hierarchy, for each version. Discussed in German-BioImaging#51.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #51. A label image must implement the multiscales specification (0.4 L462, 0.5 L421, 0.6 L1496), but the valid minimal label documents had only
image-label.The six valid
parse_attributeslabel cases now carry the multiscales of theirvalidate_zarrtwins, so they stay minimal and every implementation should agree on them. The old document becomes amissing_multiscalescase for each version, as a document and as a hierarchy.Checked with ngff-zarr: the valid cases pass and the new invalid ones fail. Schema-only validators will still accept
missing_multiscales, sincelabel.schemadoes not requiremultiscales.