Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e1bb7f1d03
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } | ||
| } | ||
|
|
||
| fun String.sha1Encode(): String = MD5Utils.sha1Encode(this) |
There was a problem hiding this comment.
When incremental sync calls this extension on a thread that has already used MD5Utils.md5Encode, it returns an MD5 digest instead of SHA-1 because MD5Digester and SHA1Digester share the same ThreadLocal<Digester>. Since the sync client uses this value for WebDAV filenames, different threads/devices can write and look up different names for the same record, causing missed pulls or duplicate cloud entries; keep separate thread-local digesters or instantiate SHA-1 independently here.
Useful? React with 👍 / 👎.
1 participant
No description provided.