Skip to content

test: re-read instead of trusting the partial-update write response #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mogita merged 1 commit into from
Aug 27, 2026
Merged

test: re-read instead of trusting the partial-update write response #149

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion chat_channel_integration_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,16 @@ func TestChatChannelIntegration(t *testing.T) {
})
require.NoError(t, err)
require.NotNil(t, resp.Data.Channel)
assert.Equal(t, "red", resp.Data.Channel.Custom["color"])

// Same read-replica caveat as the unset below: assert that the write
// applied by re-reading, not from the write response.
require.Eventually(t, func() bool {
resp, err := ch.GetOrCreate(ctx, &GetOrCreateChannelRequest{})
if err != nil || resp.Data.Channel == nil {
return false
}
return resp.Data.Channel.Custom["color"] == "red"
}, 5*time.Second, 500*time.Millisecond, "color should be set to red")

// Unset fields
_, err = ch.UpdateChannelPartial(ctx, &UpdateChannelPartialRequest{
Expand Down
Loading