Migrate poll option responses to the generated PollOptionResponse model - #6627
Migrate poll option responses to the generated PollOptionResponse model#6627gpunto wants to merge 1 commit into
Conversation
PR checklist ✅All required conditions are satisfied:
🎉 Great job! This PR is ready for review. |
SDK Size Comparison 📏
|
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (11)
WalkthroughPoll option API responses now use network-layer Moshi models. A custom adapter extracts root-level metadata, and domain mapping converts the parsed data into ChangesPoll option response handling
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |



Goal
Migrate the poll option responses from the hand-written
PollOptionResponseto the generated network models.Part of AND-1291
Implementation
PollOptionResponseandPollOptionResponseData; remove the hand-writtenPollOptionResponse.PollOptionResponseDataAdapterso the custom data the v1 endpoints flatten to the root is collected intocustom.PollsApiand mapPollOptionResponseDatato the domainOptioninDomainMapping.Testing
PollOptionResponseParsingTestcovers the option and its collected custom fields. Removing the adapter registration makes the custom assertions fail.sentiment).Summary by CodeRabbit
Bug Fixes
Tests