Repository navigation
Build the generator from chat's tools/openapi - #4290
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe OpenAPI generation script now builds the OpenAPI tool and invokes its ChangesOpenAPI client generation
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Refactor Suggested reviewers: Merge Risk: ⚪ Minimal · up to No confirmed issue blocks merging. The sibling chat repository was unavailable, so the direct generator command could not be independently checked here. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Generated by 🚫 Danger |
🔗 Issue Links
🎯 Goal
GetStream/chat#17426 moved the OpenAPI generator out of
chat-managerinto its own module,tools/openapi, in the chat repo.chat-manager openapi …is now only a compatibility path and will be removed in CHA-5626, so this script has to call the new binary before that happens.📝 Summary
Scripts/openapi_generate.shbuilds the generator withmake -C tools/openapi buildand runs./build/openapi generate-client …instead of./build/chat-manager openapi generate-client …. The subcommand and all flags are unchanged.make openapi(the chat repo's spec target) is left as it is.🛠 Implementation
It's a dev script change only. No SDK code changes, and the generated output doesn't change.
🎨 Showcase
N/A
🧪 Manual Testing Notes
Verification, against chat
origin/masterat75d154f053checked out as the sibling../chat:make -C tools/openapi buildbuildingbuild/openapi, and./build/openapi generate-clientrunning against./releases/v2/chat-clientside-api.yaml. Then I snapshottedSources/StreamChat/Generated/OpenAPI(178 files). Nothing outside that directory changed.develop. It regenerated the same spec (chat-clientside-api.yaml, sha2561b8431ff…386cc4in both runs) and ran./build/chat-manager openapi generate-client.cmp: all 178 files are byte-identical, and the file list andgit statusmatch exactly.I reverted the regenerated output afterwards, so this PR only contains the script change. The unrelated spec drift from regenerating is not included.
☑️ Contributor Checklist
docs-contentrepoSummary by CodeRabbit