Conversation
Every endpoint and the web socket now use the v2 encoding, which always nests custom data under `custom`. The generated models decode with synthesized Codable, SyncResponse keeps its tolerant events decoding in a hand-written extension, and the fixtures are converted to the v2 shape.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Generated by 馃毇 Danger |
Collaborator
SDK Performance
|
3 of 6 tasks
Collaborator
SDK Size
|
Collaborator
StreamChat XCSize
Show 140 more objects
|
Public Interface馃殌 No changes affecting the public interface. |
|
laevandus
marked this pull request as draft
September 28, 2026 09:25
laevandus
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
馃敆 Issue Links
Related: IOS-2049
Requires #4288 to merge first.
馃幆 Goal
Cleanup v1 model compatibility after migrating endpoints to v2
馃摑 Summary
馃洜 Implementation
v1 endpoints returned extra fields flattened, v2 as dedicated custom field which includes all the additional data. During incremental migration JSON decoding was injected to support a single model for both endpoints. This is not needed, but removing it requires updating JSON fixtures to match what v2 returns - custom fields.
Note that SyncResponse keeps its tolerant decoding support because WSEvent is an enum and one event would otherwise take down the whole decoding. There is a ticket to find alternatives.
馃帹 Showcase
馃И Manual Testing Notes
Manual regression tests
鈽戯笍 Contributor Checklist
docs-contentrepo