feat: configurable Opus encoder settings - #7
Merged
Merged
Conversation
- Add LocalAudioTrackConfig (bitrate, in-band FEC, expected packet loss, DTX) and LocalAudioTrack::opus_with_config. Until now the encoder ran on libopus defaults, which meant 72 kbps, no FEC despite the SDK advertising useinbandfec=1, and a full payload on every silent frame. - New defaults: 32 kbps, FEC on at 10% expected loss, DTX on. Callers who need the old behaviour can pass their own config. - Added From<opus::Error> for RtcError, matching how other dependency errors convert - Updated audio and video encoder documentation into one README section with examples for both
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add LocalAudioTrackConfig (bitrate, in-band FEC, expected packet loss, DTX) and LocalAudioTrack::opus_with_config. Until now the encoder ran on libopus defaults, which meant 72 kbps, no FEC despite the SDK advertising useinbandfec=1, and a full payload on every silent frame.
New defaults: 32 kbps, FEC on at 10% expected loss, DTX on. Callers who need the old behaviour can pass their own config.
Added Fromopus::Error for RtcError, matching how other dependency errors convert
Updated audio and video encoder documentation into one README section with examples for both