Fix VPX encoder unsafe usage - #9
Merged
Merged
Conversation
dangusev
commented
Sep 22, 2026
dangusev
commented
Collaborator
- fix: destroy the libvpx context when encoder setup fails
- ci: run the codec tests under Miri AddressSanitizer and LeakSanitizer…
- VpxEncoder::new: destroy the libvpx context when encoder setup fails - tests: cover the libvpx FFI safety assumptions: - libvpx contexts are not thread-affine (unsafe impl Send) - the boxed SVC callback survives relocation of the encoder - decoded frames own their pixels past the next decode call - copy_i420 reads dimensions per image, not once - libvpx rounds spatial layers itself at sizes that do not divide evenly
… to spot safety issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.