Repository navigation
fix(deps): clear the toml audit advisories blocking CI - #6
Merged
Merged
Conversation
effect@4.0.0-beta.103 pins toml ^4.x and three new toml-node parsing DoS advisories make the bridge job red on every PR. Effect only reaches toml through unstable/cli, which this bridge never imports, and toml is not in the built bundle, so the patched release is a safe override. Refs #5
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 55 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
pnpm audit --prodfails onmasterwith three high advisories againsttoml@4.3.0(GHSA-4qx8-w7c3-pj3p, GHSA-9j65-hcg3-gc64, GHSA-9qmh-m7c6-f92p — toml-node parsing DoS), all patched in>=5.0.1.effect@4.0.0-beta.103declarestoml: ^4.1.2, so no in-range fix exists, and the bridge job goes red for every PR — including docs-only ones.Solution
Force
toml: 5.0.1through a pnpm override and refresh the lockfile.This is safe for the shipped artifact because Effect's only use is
Toml.parse()insideunstable/cli, which this bridge never imports:grepfinds notomlinbridge/dist/t3-mini-bridge.mjs, and the rebuilt bundle is byte-identical (35efd46c…) to the committed one. The trackedlib/t3-mini-bridge-linux-x64.gzpayload therefore stays valid and needs no rebuild; CI's provenance step re-checks that against the pinned Node 24 build.Verification
pnpm audit --prod --audit-level moderate→ no known vulnerabilitiespnpm --filter @omarchy-t3/bridge build→ bundle hash unchangedpnpm test→ 84 passedCloses #5
T3 Code · opencode (deepseek-v4.1-flash-free)