fix: avoid MSBuild parallel console logger in tests - #5138
Merged
Conversation
|
Contributor
|
Thank you @arturcic for your contribution! |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the MSBuild test fixture's
ConsoleLoggerwith a focused message logger.Root cause
With Microsoft.Build 18.9.6, the Buildalyzer pipe logger can replay a message without a
BuildEventContext.ParallelConsoleLoggerrejects that event, causing otherwise unrelated MSBuild task tests to fail intermittently on macOS ARM.The replacement captures the message events asserted by the tests without routing through
ParallelConsoleLogger.Validation
dotnet test --project src/GitVersion.MsBuild.Tests/GitVersion.MsBuild.Tests.csproj --no-build --no-restore --verbosity minimal