Repository navigation
Ship a Node 24 Encryptoglyph package that does not need wasm-pack - #29
Merged
Merged
Conversation
@godesk/encryptoglyph in sdk/js and bindings/ts decrypts the shared v1, v2, and v3 vectors with node:crypto. A packed tarball installs the same envelope.js. Co-authored-by: Admin <GoDeskio@users.noreply.github.com>
cursor
Bot
force-pushed
the
cursor/js-envelope-package-fa6f
branch
from
November 14, 2026 21:01
3098891 to
ba7d58e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@godesk/encryptoglyphis a plain ECMAScript package for Node.js 24 or newer. Konektor can install it and seal credentials, approval arguments, and tool results without runningwasm-pack.Rebased onto
mainatdc054d7. The Node package stays the install path. The wasm getrandom fix from #28 stays:wasmenablesgetrandom/js, and wasm32 also enablesgetrandom0.4wasm_js.fpeandblahajstay in the crate's main[dependencies]table.bindings/tsstill hasbuild:wasmandbuild:wasm:nodefor that feature.sdk/jsis the package (envelope.jsplus the existing/v1sidecar client).package.jsonexposes the same entry, sonpm install github:GoDeskio/Encryptoglyph#<ref>works.bindings/tsships the sameenvelope.js(the test hashes both copies) and TypeScript types.sdk/js/godesk-encryptoglyph-0.2.0.tgzis the packed tarball. Itsenvelope.jsmatches the source.rewrapwrites version 3.The envelope module needs Node's
cryptoand is not a browser build.sdk/js/encryptoglyph.jsis still the browser sidecar client.Local tests
After the rebase, Rust 1.100.0, from
crates/encryptoglyph:63 tests passed, 0 failed (audit 10, envelope 11, ff1 3, index 5, kek 4, min_decryption_kid 2, offline_tool 3, policy 2, pq 1, primitives 4, secrets 1, shamir 3, shred 3, sign 2, stream 4, tenancy 1, token 2, vectors 2).
Finished. The wasm32 feature build succeeded.
Node v24.11.0:
GitHub Actions is budget-blocked. A failure that only says the Actions budget is not a failure of this package.
Install