Repository navigation
Make eg_crypto pip-installable without the API server - #31
Merged
Merged
Conversation
The api project is now eg-crypto 0.2.0. pip install of that directory installs the envelope package and not FastAPI. The README no longer says the API image skips the package. Co-authored-by: Admin <GoDeskio@users.noreply.github.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
api/eg_cryptoinstalls on its own for WatchTower-Core and any other Python service.api/pyproject.tomlis projecteg-crypto0.2.0 with a setuptools build. Dependencies arecryptography==50.0.2andPyNaCl==1.6.2.pip installof theapidirectory packageseg_cryptoonly. FastAPI and uvicorn are an optionalapiextra and remain inrequirements.txtfor the container.api/Dockerfile: the image copieseg_crypto.eg_crypto/pg.pydescribes the column ciphertext as a version-3 envelope. Version 2 still opens (min_versionis version 2).Local tests
Clean virtualenv,
pip install /path/to/api(no extras):That process decrypted
testvectors/envelope.jsonv1, v2, and v3, resealed the v3 known answer, and matched the blind index.Existing suite, from
api/withrequirements-dev.txt:ruff check apipassed.scripts/check-license-metadata.pypassed.GitHub Actions is budget-blocked. A failure that only says the Actions budget is not a failure of this package.