Shared Utilities & Infrastructure - #6896
Conversation
9708030 to
dc93fba
Compare
|
/gcbrun |
|
/cc @Nishanth29 |
|
Hi @george-kalisse-sada , it looks like the CI check Pull (bionic-baton-343) failed during execution. could you check the build failure and rerun/resolve the CI run so all checks pass? |
|
Per @george-kalisse-sada, the pull failure was likely a transient timeout issue. Zach synced to head and re-ran the check, which passed successfully(documenting here for visibility). |
| """Run a shell command, raising on failure.""" | ||
| logger.info(" CMD: %s", " ".join(cmd)) | ||
| env = os.environ.copy() | ||
| env["CLOUDSDK_AUTH_DISABLE_SSL_VALIDATION"] = "true" |
There was a problem hiding this comment.
Is CLOUDSDK_AUTH_DISABLE_SSL_VALIDATION needed here or was it left over from local testing? Can we drop this line?
| rendered = template.render(**kwargs) | ||
|
|
||
| # Write rendered YAML to tmp dir (RunKubectlCommand does not support stdin) | ||
| tmp_dir = os.path.join( |
There was a problem hiding this comment.
Doesn't writing rendered manifests to data.ResourcePath(...) creates temp files inside the repository source tree?? ig we use PKB's managed temp dir instead so it doesn't mess git or fail in read-only installs.
| import threading | ||
|
|
||
|
|
||
| _PID_FILE = "/tmp/pkb_portforward.pid" |
There was a problem hiding this comment.
Wondering if two sweeps running in parallel might overwrite this /tmp file? Maybe we can put it in PKB's temp directory or add the port to the filename.
4 participants
Files: ~10 new files
perfkitbenchmarker/linux_benchmarks/kubernetes/__init__.pyperfkitbenchmarker/linux_benchmarks/kubernetes/agentic/__init__.pyperfkitbenchmarker/linux_benchmarks/kubernetes/agentic/README.mdperfkitbenchmarker/linux_benchmarks/kubernetes/agentic/k8s_benchmark_utils.pyperfkitbenchmarker/linux_benchmarks/kubernetes/agentic/gke_deploy_utils.pyperfkitbenchmarker/scripts/agentic/__init__.pyperfkitbenchmarker/scripts/agentic/README.mdperfkitbenchmarker/scripts/agentic/gke_image_build_utils.pyperfkitbenchmarker/scripts/agentic/gke_prerequisites.pyperfkitbenchmarker/scripts/agentic/gke_post_teardown.pyDescription: Adds shared infrastructure for GKE Agent Sandbox benchmarks:
k8s_benchmark_utils.py— Agent API interaction, kubectl helpers, warm pool management, port-forward manager, PKB sample constructiongke_deploy_utils.py— Idempotent deployment of Agent Sandbox ecosystem (CRDs, SandboxTemplates, WarmPools, Router, ADK Agent) onto pre-provisioned GKE clustersgke_image_build_utils.py— Container image builds (Chrome Sandbox, Sandbox Router) via Google Cloud Build with cross-architecture support (amd64/arm64)gke_prerequisites.py— One-time GCP project setup (APIs, Artifact Registry, Cloud Build SA, image builds including native ARM64 VM builds)gke_post_teardown.py— Cleanup of resources created by prerequisites