Skip to content

#4664 Remove duplicate Promethium alarm tone - #436

Open
White-Sand-Knight wants to merge 1 commit into
GrapheneOS:17from
White-Sand-Knight:fix-4664-remove-duplicate-promethium-alarm
Open

#4664 Remove duplicate Promethium alarm tone#436
White-Sand-Knight wants to merge 1 commit into
GrapheneOS:17from
White-Sand-Knight:fix-4664-remove-duplicate-promethium-alarm

Conversation

@White-Sand-Knight

Copy link
Copy Markdown

Refs #4664

Removes the duplicate Promethium alarm tone.

Promethium.ogg is byte-identical to Platinum.ogg (md5 01821ed2), and both carry the embedded title 'Platinum', so the alarm picker lists Platinum twice. Remove the duplicate file plus its build references in Android.bp, AllAudio.mk and AudioPackage8.mk.

Bug: GrapheneOS/os-issue-tracker#4664 Test: built for sdk_phone64_x86_64, verified on the emulator that the alarm picker shows a single 'Platinum' entry (17 unique oggs)

Promethium.ogg is byte-identical to Platinum.ogg (md5 01821ed2),
and both carry the embedded title 'Platinum', so the alarm picker
lists Platinum twice. Remove the duplicate file plus its build
references in Android.bp, AllAudio.mk and AudioPackage8.mk.

Completes the cleanup AOSP deferred in 70908dd
(Bug 190080582).

Bug: GrapheneOS/os-issue-tracker#4664
Test: built for sdk_phone64_x86_64, verified on the emulator that
the alarm picker shows a single 'Platinum' entry (17 unique oggs)
@muhomorr

muhomorr commented Sep 1, 2026

Copy link
Copy Markdown
Member

What happens if the duplicate was previously selected by the user as the current alarm tone?

@White-Sand-Knight

White-Sand-Knight commented Sep 1, 2026

Copy link
Copy Markdown
Author

What happens if the duplicate was previously selected by the user as the current alarm tone?

this use case was not checked let me check it out and get back to you.

@White-Sand-Knight

White-Sand-Knight commented Sep 1, 2026

Copy link
Copy Markdown
Author

@muhomorr It was checked using emulator that it does play the sound that is same as platinum after we removed the duplicate even if the duplicate was selected.

@muhomorr

muhomorr commented Sep 1, 2026

Copy link
Copy Markdown
Member

Which duplicate have you selected? They have different Uris on my device:

<select first Platinum>

% adb shell settings get system alarm_alert
content://media/internal/audio/media/211?title=Platinum&canonical=1

<select second Platinum>

% adb shell settings get system alarm_alert
content://media/internal/audio/media/214?title=Platinum&canonical=1

@White-Sand-Knight

White-Sand-Knight commented Sep 1, 2026

Copy link
Copy Markdown
Author

@muhomorr the ids got changed for me. but the deleted one is the one that points to the promethium.
adb shell settings get system alarm_alert content://media/internal/audio/media/139?title=Platinum&canonical=1

adb shell settings get system alarm_alert content://media/internal/audio/media/222?title=Platinum&canonical=1
the 222 id for me is the one that points to promethium and it is the second on in the gui (the second platinum)

@White-Sand-Knight

Copy link
Copy Markdown
Author

@muhomorr is there any other issues?; please tell so it can be checked.

@muhomorr

muhomorr commented Sep 6, 2026

Copy link
Copy Markdown
Member

The issue that I've described above isn't fixed from what I can see. If the user selected the duplicate then the selection will be lost unless I've missed something. This defect has a very low priority.

@White-Sand-Knight

White-Sand-Knight commented Sep 6, 2026

Copy link
Copy Markdown
Author

started this issue as good first issue and as it also had similar fixes done in AOSP so started it.
The selection is lost as in there is nothing selected on the alarm sound options but it does play the sound of the platinum still this all was tested on emulator.

@White-Sand-Knight

Copy link
Copy Markdown
Author

Also learning to how to contribute to opensource and AOSP so help is need.
any way thanks for your feed back and responses till now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants