Repository navigation
Update OpenAI models to the GPT-6 lineup - #3
Merged
Merged
Conversation
- Offer current models in Settings (gpt-6-luna, gpt-6-astra, gpt-6.1-sol, gpt-6-sol, gpt-5.6-sol/terra/luna) and drop deprecated or shut-down ones (gpt-4o, gpt-4.1*, gpt-5/-mini/-nano, gpt-5-chat-latest). - Default to gpt-6-luna, OpenAI's recommended replacement for gpt-4o. - Treat every GPT model from GPT-5 onward as a reasoning model so GPT-6 requests send max_completion_tokens and no temperature instead of failing with HTTP 400. - Switch saved retired models to gpt-6-luna once, tracked by a new SettingsVersion registry value so a later explicit choice is kept. - Move the model checks into ModelParams and cover them with unit tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
🔵 Needs a closer look
Model availability, retirement assumptions, and API compatibility remain unverified, and persistence of reselected older models needs confirmation.
0 open findings
What changed in this PR
Updates the plugin’s model choices and default, extends reasoning-model request handling, and introduces versioned migration of saved model settings.
Changes:
- Replaces preset models and sets
gpt-6-lunaas the default. - Extracts model classification helpers and adds unit tests.
- Adds a one-time migration for models classified as retired.
| File | Description |
|---|---|
| tests/CoreTests.cpp | Adds model classification tests. |
| src/SettingsDialog.cpp | Updates selectable model presets. |
| src/ModelParams.h | Declares model classification helpers. |
| src/ModelParams.cpp | Implements reasoning and retirement checks. |
| src/LLMService.cpp | Updates the default and adds versioned settings migration. |
| LLMAssistant.vcxproj | Includes the new helpers in the plugin build. |
| CMakeLists.txt | Includes model helpers in the test target. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gpt-6-luna,gpt-6-astra,gpt-6.1-sol,gpt-6-sol,gpt-5.6-sol,gpt-5.6-terra,gpt-5.6-luna. Removed models OpenAI has deprecated or shut down:gpt-4o,gpt-4.1*,gpt-5/-mini/-nano,gpt-5-chat-latest. The combo box is still editable, so any model name can be typed in.gpt-6-luna, OpenAI's recommended replacement forgpt-4o.max_completion_tokensand notemperature. Previously onlygpt-5*and the o-series were, so GPT-6 requests sentmax_tokensandtemperature: 0.7, which those models reject.gpt-6-lunaonce. A newSettingsVersionregistry value records that the switch ran, so if someone picks an older model again later, that choice is kept.src/ModelParams.{h,cpp}and are covered by new unit tests.Model IDs and deprecation dates are from OpenAI's models and deprecations pages.
Testing
gpt-5-minisetting. Settings showedgpt-6-luna, Test Connection succeeded withgpt-6-luna, and the registry was saved asModel = gpt-6-luna,SettingsVersion = 1.🤖 Generated with Claude Code