Repository navigation
Release 1.2: x86 and ARM64 builds - #8
Merged
Merged
Conversation
Notepad++ only loads plugins built for its own architecture, so 32-bit and ARM64 users can't use the x64 DLL. - LLMAssistant.vcxproj: add Win32 and ARM64 Debug/Release configurations. Settings now depend only on the configuration, and every platform builds to <Platform>\<Configuration>\ (Win32\Release\LLMAssistant.dll). - build.bat: take an optional platform (x64 default, x86/Win32, arm64) and look for the ARM64 build tools component when building for ARM64. deploy.bat asks for x64 explicitly. - make-release-zip.ps1: add -Platform. Before packaging, check the DLL's machine type, version resource and Notepad++ exports, then name the zip _x64, _x86 or _arm64 and print the entry for pl.<platform>.json. - CI: build x64, Win32 and ARM64, also run the tests as 32-bit, package three zips with make-release-zip.ps1, and attach all three to the release on a v* tag. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The windows-2025-vs2026 runner has v143 (MSVC 14.44) for x64 and x86 only, so msbuild failed with MSB8020 for ARM64. Build ARM64 with the project's own v145 toolset and keep v143 for x64 and Win32. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The DLL linked the CRT dynamically (/MD), so Notepad++ could only load it where the VC++ Redistributable for the same architecture was installed. That's more likely to be missing for 32-bit and ARM64 users, and the ARM64 DLL is built with v145, so it needs version 14.50 or later. Use /MT and /MTd, as the Notepad++ plugin template does. The DLL now imports only Windows system DLLs. Release grows from 102 to 312 KB (x64) and from 94 to 263 KB (x86). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
1.2 is the first release with x86 and ARM64 builds and with the static C runtime. Plugins Admin compares the DLL's version resource with the nppPluginList entry, so all three lists get the new version. The user docs now describe the per-architecture zips instead of 64-bit only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the plugin to 1.2, the first release with x86 (32-bit) and ARM64 builds. It builds on #6 (x86/ARM64 builds and packaging) and #7 (static C runtime). This PR targets
mainand contains their commits, so it shows all three until they merge. Merge #6, then #7, then this one, using merge commits. Merging only this PR with a merge commit also lands all three.Changes
src/Version.h: 1.1 → 1.2. Plugins Admin compares the DLL's version resource with the nppPluginList entry, and the x86 and ARM64 lists get their first entry at this version.README.md,INSTALLATION_GUIDE.md: the requirements, manual install and troubleshooting text now describe the per-architecture zips (_x64,_x86,_arm64) instead of "64-bit only". They also give the 32-bit install folder (C:\Program Files (x86)\Notepad++\plugins\LLMAssistant\) and how to check your Notepad++ architecture.Verification
build.batandbuild.bat x86build with 0 warnings.make-release-zip.ps1 -Version 1.2passes for both: version 1.2.0.0, correct machine type, all six exports.After merge (release steps)
v1.2on the merge commit and push the tag. The workflow builds the three DLLs, checks that each one reports 1.2.0.0 (it fails if the tag doesn't match), and publishes the release withLLMAssistant_v1.2_x64.zip,_x86.zipand_arm64.zip. The release notes include the three nppPluginList entries with their SHA-256s.🤖 Generated with Claude Code