Repository navigation
feat(app): drag a Block Type from the Block Palette onto the Worksheet (#6) - #17
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6
Summary
Two non-obvious points:
deltaincludes scrolling, so the pointer position is tracked directly. Otherwise a mid-drag scroll puts the drop at the wrong index.Evidence
["", "", ...]).After: line and drop both at 20. Typing lands in every dropped Block:
["C","F","E","D","A","B"].Driven with real mouse input in Firefox (drag, drop, append, grey area, outside, Escape, click, scroll) and WebKitGTK (typing after each drop). Not run in the Tauri shell itself.
Merge Danger
Door: two-way
Blast Radius: Worksheet
Adds
@dnd-kit/core. The Escape key also clears the selected Block during a drag, through the Worksheet's existing handler. The Linux Tauri criterion is verified only through WebKitGTK, notpnpm tauri dev.🤖 Generated with Claude Code