Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QSSTV source builds now run unprivileged and promote only checked artifacts.
Static Verification Checks
Build privilege boundary (Passed) — Static inspection of tasks/main.yml, without runtime checks, shows Git, qmake, make, and ldd lack root authority.
Mutable update pinning (Passed) — defaults/main.yml disables refreshes, while source-ref validation permits updates only for full commit IDs, blocking moving-ref convergence.
Artifact promotion boundary (Passed) — promote-artifact.yml rejects symlinks and ownership mismatches, compares SHA-256 digests, then atomically installs artifacts, preventing privileged dereference bypasses.
Default install continuity (Passed) — defaults/main.yml retains the HRV repository and initial main ref while disabling refreshes, preserving first-install behavior.
Caller behavior preserved (Passed) — sstv-rx and sstv-workstation still include qsstv-runtime behind existing install flags, preserving opt-in QSSTV deployment.
Regression assertions retained (Passed) — scripts/qa.py asserts non-root execution, immutable update IDs, no-follow staging, and checksum matching, protecting the boundary.
Finding:
acf_74a4b030b60e7a53897a68b2f9d77164Patch:
arp_ae2e4acbb9c774244452504c2d529b84Base commit:
0ffb68937bc72420999f9d67bc8af90feb1ef617Patch SHA-256:
564d60dae831e059b33809de61352654d996438675f9769b48c64e99300b44d9