Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The patch makes HamStack netboot TLS-only and requires trusted signatures before iPXE executes boot content.
Static Verification Checks
TLS publication boundary (Passed) — roles/infrastructure/netboot/tasks/main.yml maps the host listener only to TLS port 443, eliminating the plaintext network entrypoint.
TLS server authentication (Passed) — roles/infrastructure/netboot/templates/nginx.conf.j2 configures certificate-backed TLS without HTTP, establishing authenticated initial menu delivery.
Chain signature gate (Passed) — roles/infrastructure/netboot/templates/boot.ipxe.j2 fetches, verifies, then executes chain images, closing substituted-script execution.
Boot image signature gate (Passed) — roles/infrastructure/netboot/templates/boot.ipxe.j2 verifies named kernels and optional initrds before boot, closing altered-image execution.
Unsafe entry rejection (Passed) — roles/infrastructure/netboot/tasks/main.yml requires HTTPS artifacts and signatures for both schemas, preventing unsigned configuration bypasses.
Legitimate workflow preservation (Passed) — roles/infrastructure/netboot/templates/boot.ipxe.j2 retains chain, kernel, initrd, arguments, and menus, establishing preserved boot workflows.
Port override compatibility (Passed) — roles/infrastructure/netboot/defaults/main.yml aliases HTTPS to the legacy port variable, establishing existing overrides remain effective.
Static evidence scope (Passed) — The final source and diff inspection supplied evidence; runtime checks were not performed in static mode.
Finding:
acf_2a2f856ef1a2100c1a173904b0327384Patch:
arp_c141f38de9bec711cf4ac941a2488aadBase commit:
0ffb68937bc72420999f9d67bc8af90feb1ef617Patch SHA-256:
be0a4805f7ba3951acdafdfda39bf411314cb2c1ce8fc6c2b82e98641950f5f2