fix: typing for message_handler - #5
Conversation
ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Free Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe change updates type hints in harbor/mqtt.py to allow the message_handler callback to return HarborEvent | None instead of None, using postponed annotation evaluation and a TYPE_CHECKING import. A corresponding test is added to verify compatibility. ChangesMQTT Message Handler Type Update
Estimated code review effort: 1 (Trivial) | ~5 minutes Poem
Note 🎁 Summarized by CodeRabbit FreeYour organization has reached its limit of developer seats under the Pro Plan. For new users, CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please add seats to your subscription by visiting https://app.coderabbit.ai/login.If you believe this is a mistake and have available seats, please assign one to the pull request author through the subscription management page using the link above. Comment |
Same typing fix so that mypy passes for HA
Summary by CodeRabbit
Bug Fixes
Tests