Skip to content

Fix the v5 migration guide's transaction example - #606

Merged
Ethan-Arrowood merged 1 commit into
mainfrom
kris/fix-v5-migration-transaction-import
Jul 29, 2026
Merged

Fix the v5 migration guide's transaction example#606
Ethan-Arrowood merged 1 commit into
mainfrom
kris/fix-v5-migration-transaction-import

Conversation

@kriszyp

@kriszyp kriszyp commented Jul 27, 2026

Copy link
Copy Markdown
Member

Adds the missing transaction import so the Transactions and Context example is self-contained.

Generated by Codex.

@kriszyp
kriszyp requested a review from cb1kenobi July 27, 2026 01:06

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the v5 migration documentation to include the import of transaction from 'harper' in a JavaScript code example. There are no review comments, and I have no additional feedback to provide.

@github-actions
github-actions Bot temporarily deployed to pr-606 July 27, 2026 01:09 Inactive
@github-actions

Copy link
Copy Markdown

🚀 Preview Deployment

Your preview deployment is ready!

🔗 Preview URL: https://preview.harper-documentation.harperfabric.com/pr-606

This preview will update automatically when you push new commits.

@kriszyp
kriszyp marked this pull request as ready for review July 27, 2026 01:10
@kriszyp
kriszyp requested a review from a team as a code owner July 27, 2026 01:10
@kriszyp
kriszyp removed the request for review from a team July 27, 2026 01:10

@Ethan-Arrowood Ethan-Arrowood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the fix against the harper module exports at main — the synthetic harper module does export transaction alongside getContext, and the callback overload matches the example's usage.

sent with Claude Opus 5

@Ethan-Arrowood
Ethan-Arrowood merged commit de314d5 into main Jul 29, 2026
7 checks passed
@Ethan-Arrowood
Ethan-Arrowood deleted the kris/fix-v5-migration-transaction-import branch July 29, 2026 16:24
@github-actions

Copy link
Copy Markdown

🧹 Preview Cleanup

The preview deployment for this PR has been removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants