fix(ai-chat): reset conversations loading state on failure - #9
Closed
AshSgDe29071999 wants to merge 1 commit into
Closed
fix(ai-chat): reset conversations loading state on failure#9AshSgDe29071999 wants to merge 1 commit into
AshSgDe29071999 wants to merge 1 commit into
Conversation
|
@AshSgDe29071999 is attempting to deploy a commit to the haveniceda's projects Team on Vercel. A member of the Team first needs to authorize it. |
Ensure refreshConversations clears isLoadingConversations via try/finally when loadConversations rejects, and cover the failure path with a unit test.
AshSgDe29071999
force-pushed
the
fix/ai-chat-conversations-loading-reset
branch
from
August 2, 2026 14:37
125f575 to
c569ba3
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isLoadingConversationsalways resets tofalseon success or failure.falsewhenloadConversationsrejects.Closes #7
Test plan
pnpm exec vitest run src/components/ai-chat/refreshConversations.test.ts(fromapps/web)loadConversationsfailure, confirm list is not stuck loading