Repository navigation
docs: 合并后对账 CI 状态并修正共享类可见性 - #2
Merged
Merged
Conversation
- 复现 §7 记录的缺陷:ScenarioEngine.Run 接受独立的 workflow 与 graph,外部传入不匹配的一对会抛 KeyNotFoundException - ScenarioEngine 收窄为 internal,WorkflowAnalyzer 成为唯一 public 入口;ScenarioRunner 过滤无法定位的 job id 并为每个产出 INT001/Internal/Error 诊断,不抛异常也不编造结果 - 批量收窄 27 个实现细节类型为 internal;边界由编译器的可访问性规则决定,15 个被 public 签名引用的契约类型保留 public - 新增 ScenarioEngineMismatchTests(含 A/B 复现)与 PublicSurfaceTests(11 条护栏断言) - §17 / CHANGELOG 记录边界判定方法与仍未做的拆超长文件
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景
PR #1 已于 2026-11-05 15:28 合并(squash 为
f07a096),dev首次push门禁 run41987481649两个 job 均success。dev受保护,本批改动从最新dev另开分支、另开 PR。改动
Text/EditDistance.cs与Values/JsonValueConverter.cs上批误写成public,反向扩大了 public 面,与 F 裁决方向相悖。改回internal(项目已配置InternalsVisibleTo,测试不受影响),并新增SharedHelpers_AreNotPartOfThePublicApi反射断言防止回退。CHANGELOG.md:删掉「working-copy edits … uncommitted」「dev has not triggered CI yet」,改为列出全部四次真实 CI 运行(41977057618/41981780325/41986150317/41987481649)。docs/limitations.md:dev分支已有绿灯 run,不再写「has not had a run yet」。docs/review-v1-grill.md§15:移除过时的「精度边界」,更新为合并后复核(PR chore(ci): 让 Gate 2 覆盖 dev 并对齐仓库状态 #1MERGED、devpush 首绿、改后 workflow 已在 PR 与 push 两种事件下跑绿),重列仍待执行项;§16 补记internal修正。本地验证
dotnet build ActionLens.sln -v q --nologo→ 0 errors / 0 warningsdotnet format ActionLens.sln --verify-no-changes→ 0npm run test:e2e→ 8 / 8无 workflow 配置改动;CI 会由
pull_request事件照常触发。仍待执行(未在本 PR)
dev→main评审 PR、Pages 首次部署与首个 release、§16 留下的「收窄 public 面 / 拆超长文件」、ADR 0003 Deferred 产品功能(Q2 已否决,须重开 ADR)。追加提交
49a3450— 收窄 public 面并修复不一致 graph 导致的异常ScenarioEngine.Run接受独立的workflow与graph,外部传入不匹配的一对会抛裸KeyNotFoundException。新增ScenarioEngineMismatchTests复现(one.yml模型 +two.ymlgraph);A/B 验证确认恢复裸索引后该用例重新失败。
ScenarioEngine收窄为internal,WorkflowAnalyzer成为唯一 public 入口;ScenarioRunner在遍历前用_jobs.ContainsKey过滤无法定位的 id,并为每个产出INT001/Internal/Error诊断说明原因。不抛异常,也不给无定义的 job 编造结果。批量改为
internal,按编译器 CS0050/51/53/60 的可访问性错误迭代回退 3 轮收敛。最终 27 个收窄(含
LintEngine),15 个保留 public——它们出现在 public 签名里,是 JSON 导出与 UI 真正依赖的契约。边界由编译器决定,不靠猜测。
PublicSurfaceTests(11 条断言)钉住该边界,防止未来「改成 public 更方便」的回退。验证(追加提交后):
dotnet build0/0 ·dotnet format --verify-no-changes0 ·Core 1430 / 1430 · Ui 25 / 25 · Playwright 8 / 8 ·
本 PR CI run
42000411644两 job 均success。仍未做:拆超长文件(
WorkflowModelBuilder1444 行等,纯机械重构)、Pages 首次部署与首个 release、ADR 0003 Deferred 产品功能(Q2 已否决,须重开 ADR)。