Repository navigation
P3 收尾: 收敛构造重复、editor.ts 类型修正、seed 脚本可移植 - #6
Open
wubing7755 wants to merge 5 commits into
Open
wubing7755 wants to merge 5 commits into
wubing7755 wants to merge 5 commits into
Conversation
UnknownDecision 辅助方法统一 7 处 unknown 决策(note 与 reason 不再 可能漂移),EvaluateEvent 三个出口共用 Verdict 局部函数;1430 全绿。
链接/一元/比较操作数共用传播辅助方法;短路逻辑与函数参数的 条件传播形状不同,保持原样;求值顺序不变,1430 全绿。
Held 改为 view/observer 构造完成后一次性赋值(监听器只在事务时触发, 闭包不会见到未赋值状态);顺带修正验证中发现的既有类型错误: DecorationSet 改从 @codemirror/view 导入、RangeSet.map 去掉多余第二参。 tsc --strict 干净,Playwright 8 用例全绿。
硬编码的开发机路径移入 scripts/offline-sources.local.json(不入库), 搜索顺序与版本拒绝行为逐字保持;本机配置已就位。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
质量报告 P3 遗留项全部收尾(承接 #5):
UnknownDecision统一 7 处 unknown 决策构造、EvaluateEvent三出口共用Verdict局部函数;EvaluateOrPropagate统一 7 处 unknown 传播构造(短路逻辑与函数参数的条件传播形状不同,保持原样)Held改为构造完成后一次性赋值,消除null as unknown as双重断言;顺带修正 tsc 验证中发现的两处既有类型错误(DecorationSet导入源、RangeSet.map多余第二参)scripts/offline-sources.local.json,搜索顺序与版本拒绝行为逐字保持(原版脚本对照证实)Test plan
dotnet format --verify-no-changes通过tsc --strict --noEmit干净