Repository navigation
fix: audio test hardening - #52
Merged
Merged
Conversation
…g, serialize plugin host tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Expands regression coverage across the audio engine and frontend, fixes the production defects the new tests exposed, and removes timing flakiness from the suite.
Production fixes
Coverage
ParamRing: ordering, multi-reader broadcast, lagging-reader catch-up, no torn events under concurrent writers.deriveSlots,freeRunFrom).proptest) only for stable invariants (finite output, ceiling, bounded gain); curves and timing use deterministic examples. Compressor regression seed is committed.Test stability
netaudio::receiver: the receiver binds its socket in a spawned task, so the single early datagram could be lost. The test now resends until counted.playback_pulls_samplesneeds a specific ALSA sink; marked#[ignore]and removed the--skipfromci.yml.globalThis.fetch; dropped a hardcodedPIPELINE_VERSIONassertion.Small refactor
parse_ctrlso it can be tested. Behavior unchanged.Tooling
bun run test/bun run checkrun frontend and Rust concurrently.cargo clippy --all-targetsis clean (test sines useTAU).New dev dependencies:
proptest(DSP invariants, persisted failing cases) and Tauri'stestfeature (app test harness, not enabled in release).The final suite contains 447 Rust library tests, 3 Rust integration tests, and 83 frontend tests.
Checklist
bun run testpassesbun run checkpassesbun run formatleaves the tree clean#[derive(TS)]contract changed)DspWorker::runPlatform coverage
bun run test: all frontend and Rust tests pass, including real AU/CLAP/VST3 plugins and stereo/mono AAC round tripscargo llvm-cov --lib --summary-only: 71.75% line coverage (measured before the last round of added tests)bun run check: 0 errors, 21 pre-existing Svelte warningscargo clippy --all-targets: cleanPlatform-neutral
pipeline/inputandpipeline/outputchanged; CoreAudio, PipeWire and WASAPI backends did not. The AAC fix is macOS-only (AVFoundation).