Repository navigation
fix(plugins): scan once per change, not once per node, from an on-disk cache - #65
Merged
Merged
Conversation
…flag missing plugins
…n thread, symlink loops in search dirs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the pipeline editor hanging for minutes when a pipeline has several plugin nodes (#60). Every plugin node ran its own full scan on mount, loading every installed CLAP/VST3 binary (VST3 on the main thread).
pluginCatalog). A saved node triggers at most one scan per session to check that its plugin is still installed, and shows its stored name meanwhile. Opening a dropdown refreshes the list.plugins.jsonin the app cache dir. Only new or changed bundles are opened; removed ones are dropped.Why is this the right approach?
This is how DAWs handle large plugin libraries: a persistent plugin list, reopening only bundles that changed, and nodes that don't each trigger their own scan. A bundle counts as changed when the latest mtime or total size of its files changes (skipping
Resources), since installers often leave the bundle folder's own mtime unchanged.The cache is dropped on every app update, so a new release never relies on an older one's scan results.
Possible future improvement (not a priority now): scan plugins in a separate process with a timeout, so the first scan doesn't freeze the UI and a crashing plugin can't take the app down.
Checklist
bun run checkpassescargo check --manifest-path src-tauri/Cargo.tomlpassesbun run formatleaves the tree cleanPlatform coverage
No per-OS files are touched.
Related