Skip to content

fix(cd): skip ssh deploy when unconfigured #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ha1zyy merged 1 commit into from
Jun 7, 2026
Merged

fix(cd): skip ssh deploy when unconfigured #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 42 additions & 2 deletions .github/workflows/cd.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,11 +119,50 @@ jobs:
cache-from: type=gha
cache-to: type=gha,mode=max

# ── Check whether SSH deployment is configured ───────────────────────────
deploy-config:
name: Check deploy configuration
needs: guard
runs-on: ubuntu-latest
outputs:
production_ready: ${{ steps.check.outputs.production_ready }}
staging_ready: ${{ steps.check.outputs.staging_ready }}
steps:
- name: Check deployment settings
id: check
env:
DEPLOY_PATH: ${{ vars.DEPLOY_PATH }}
SSH_HOST_PRODUCTION: ${{ secrets.SSH_HOST_PRODUCTION }}
SSH_HOST_STAGING: ${{ secrets.SSH_HOST_STAGING }}
SSH_KNOWN_HOSTS: ${{ secrets.SSH_KNOWN_HOSTS }}
SSH_PRIVATE_KEY: ${{ secrets.SSH_PRIVATE_KEY }}
SSH_USER: ${{ secrets.SSH_USER }}
run: |
staging_ready=true
for name in DEPLOY_PATH SSH_HOST_STAGING SSH_KNOWN_HOSTS SSH_PRIVATE_KEY SSH_USER; do
if [[ -z "${!name}" ]]; then
echo "::notice::${name} is not configured; staging SSH deploy will be skipped"
staging_ready=false
fi
done

production_ready=true
for name in DEPLOY_PATH SSH_HOST_PRODUCTION SSH_KNOWN_HOSTS SSH_PRIVATE_KEY SSH_USER; do
if [[ -z "${!name}" ]]; then
echo "::notice::${name} is not configured; production SSH deploy will be skipped"
production_ready=false
fi
done

echo "staging_ready=${staging_ready}" >> "$GITHUB_OUTPUT"
echo "production_ready=${production_ready}" >> "$GITHUB_OUTPUT"

# ── Deploy to staging ─────────────────────────────────────────────────────
deploy-staging:
name: Deploy to staging
needs: [guard, build-push]
needs: [guard, build-push, deploy-config]
runs-on: ubuntu-latest
if: ${{ needs.deploy-config.outputs.staging_ready == 'true' }}
environment:
name: staging
url: https://staging.metrixplatform.com
Expand Down Expand Up @@ -234,8 +273,9 @@ jobs:
# ── Deploy to production ──────────────────────────────────────────────────
deploy-production:
name: Deploy to production
needs: [guard, smoke-staging]
needs: [guard, smoke-staging, deploy-config]
runs-on: ubuntu-latest
if: ${{ needs.deploy-config.outputs.production_ready == 'true' }}
environment:
name: production
url: https://metrixplatform.com
Expand Down
4 changes: 4 additions & 0 deletions docs/deployment/CD.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,10 @@ GHCR/Docker repository path должен быть lowercase, иначе `docker

`production` с required reviewers — это и есть ручной approval gate.

Если SSH secrets или `DEPLOY_PATH` не настроены, pipeline только соберёт и
опубликует GHCR images, а SSH deploy jobs будут skipped с notice в CD run.
Это защищает `main` от красного CD в репозиториях без подключённых серверов.

## Необходимые секреты

Добавить в GitHub Settings → Secrets → Actions:
Expand Down
Loading