Skip to content

fix for add from pool bug (long loading time) mantis 47724 #11821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mglaubitz wants to merge 6 commits into
base: release_10
Choose a base branch
from
+591 −96
Open

fix for add from pool bug (long loading time) mantis 47724 #11821

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c8946ab
Performance(TestQuestionPool): two-phase query for question browser +…
Jul 24, 2026
7f64aea
Docs(TestQuestionPool): performance plan for question browser two-pha…
Jul 24, 2026
2554832
Performance(TestQuestionPool): unified two-phase query path per core …
Jul 29, 2026
0a00072
Fix(TestQuestionPool): restore newline-separated query parts in build…
Jul 29, 2026
ee40e97
Remove PERFORMANCE_PLAN.md from repo root (breaks RootFolderTest)
Jul 30, 2026
7f9e7ab
Performance(TestQuestionPool): granular computed fields, table consta…
Jul 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions components/ILIAS/TestQuestionPool/classes/Setup/class.ilTestQuestionPool10DBUpdateSteps.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,4 +47,23 @@ public function step_2(): void
$this->db->dropTableColumn('qpl_questionpool', 'show_taxonomies');
}
}

/**
* Composite index supporting the paginated question browser query
* (ilAssQuestionList two-phase loading, phase A) which filters by
* obj_fi (eq / IN) and original_id IS NULL and commonly orders by
* title. Covers both the pool-internal view (obj_fi = X) and the
* "add from pool" browser (obj_fi IN (...)) of ilObjTestGUI.
*
* Note: ILIAS' ilDBPdoFieldDefinition::checkIndexName limits index
* names to 3 characters, hence the short name "i6" (the existing
* i1_idx..i5_idx on this table predate that constraint).
*/
public function step_3(): void
{
$fields = ['obj_fi', 'original_id', 'title'];
if (!$this->db->indexExistsByFields('qpl_questions', $fields)) {
$this->db->addIndex('qpl_questions', $fields, 'i6');
}
}
}
Loading
Loading