Repository navigation
Apple container - #3
Merged
Merged
Conversation
Move all the code that assembles the command line to invoke the `docker` command into a separate public function. This will allow to reuse that function from other backends that are reusing the same command line interface as the `docker` command.
Add a new backend that relies on Apple's `container` command to create and run a container from a Docker image. closes #1
When printing the help message, do not show options corresponding to backends that are not available on the current system.
The Apple Container backend should not assume that the entire physical memory is available to the containers. It should instead query the container service to obtain whatever value the service is configured to use.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new backend, selected with the
--appleoption, that relies on Apple’scontainercommand to create and run a container from a Docker image.This is quite straightforward as the
container runcommand has been expressly designed to have the same interface as Docker’sdocker runcommand.Still unclear: Can we forward a SSH socket into the container?
closes #2