Derive the suite count in release.mjs from the runner - #6
Merged
Conversation
It printed "all 8 suites pass" while there were nine, having been written down when there were eight. all.mjs already reports the count in its own summary line, so read that instead of keeping a second copy of the number. Same fault as the ROW_H literal in tree.mjs and the hand-tallied chrome constants in the outline and Claims height caps: a number recorded in a second place that is really a consequence of the first. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
release.mjsstep 4 printedall 8 suites passwhile there were nine — thecount was written down when there were eight and never moved.
all.mjsalreadyreports it in its own summary line, so read that rather than keep a second copy
of the number.
Cosmetic in effect: the step still passes or fails on the runner's exit code,
so nothing was mis-gated. But it is the same fault as the
ROW_H === 24literalin
tree.mjsand the hand-tallied chrome constants behind the outline andClaims height caps — a number recorded in a second place that is really a
consequence of the first — and this one sits in the script that cuts releases.
Verified:
node web/tests/all.mjsgreen, and arelease.mjsdry run nowreports the real count.
🤖 Generated with Claude Code